Project

General

Profile

Actions

action #169840

closed

coordination #169657: [epic] Handle test fixes and adjustments

Fix changed hotkey shortcuts and layout in iscsi_client

Added by rainerkoenig about 1 month ago. Updated 24 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
2024-11-13
Due date:
% Done:

0%

Estimated time:

Description

Motivation

The scsi/iscsi_client.pm test module is experiencing errors in YaST Maintenance Updates.
The reason is that in the test module there are hardcoded shortcuts for UI elements, and those shortcuts now changed slightly.
Also the layout of some screens could look different now what leads to not matching needles.

Related bug: https://bugzilla.suse.com/show_bug.cgi?id=1231385

Additional information

The tests using this test module are:

  • iscsi_client_normal_auth_backstore_fileio
  • iscsi_client_normal_auth_backstore_hdd
  • iscsi_client_normal_auth_backstore_lvm

Those test suites are used in both YaST (group ID=129) and MU (group ID=421), so we cannot just easily change the hotkeys form "old" to "new" because if we try to fix MU with this then we break the same tests in YaST.

Acceptance criteria:

  • AC1: Make the shortcut conditional to the products affected without breaking previous functionality where the update didn't reach yet.
Actions #1

Updated by JERiveraMoya about 1 month ago

  • Tags set to qe-yam-nov-sprint
  • Status changed from New to Workable
  • Priority changed from High to Urgent
  • Parent task set to #169657
Actions #2

Updated by JERiveraMoya about 1 month ago

  • Description updated (diff)
Actions #4

Updated by JERiveraMoya about 1 month ago

  • Subject changed from Fix changed hotkey shortcuts and laysout in iscsi_client to Fix changed hotkey shortcuts and layout in iscsi_client
Actions #5

Updated by rainerkoenig about 1 month ago

  • Status changed from Workable to In Progress
  • Assignee set to rainerkoenig
Actions #6

Updated by rainerkoenig about 1 month ago

Adapting the hot keys specific to 15-SP6.
Iterating trough the errors that you encounter every time after you fixed one thing.

Actions #7

Updated by rainerkoenig about 1 month ago · Edited

Looks more like a bug in YaST iscsi client: https://openqa.suse.de/tests/15932198#step/iscsi_client/56

Actions #8

Updated by JERiveraMoya about 1 month ago

rainerkoenig wrote in #note-7:

Looks more like a bug in YaST iscsi client: https://openqa.suse.de/tests/15932198#step/iscsi_client/56

most likely we should file a bug asap, draft pr?

Actions #10

Updated by JERiveraMoya about 1 month ago

Let's ensure we have the fix in the list of maintenance updates https://build.suse.de/request/show/353628 to keep tackling this.
we should mention in maintenace slack channels as well, I'm not sure how is the handling there, but we need the current patch that broke the automation but created that bug in combination with the bug fix...

Actions #11

Updated by JERiveraMoya about 1 month ago

  • Priority changed from Urgent to Normal

changing priority at least during hackweek.

Actions #12

Updated by JERiveraMoya 25 days ago

  • Status changed from In Progress to Resolved

Could you add the PR needed for this as history ? I will resolve it.

Actions #13

Updated by rainerkoenig 25 days ago · Edited

  • Status changed from Resolved to In Progress

The first PR (with typos) and the PR to fix the typos were hard-coded to match for SP6 where the hotkeys for YaST changed.

With SP7 Build 41.1 the changes in YaST now also affect SP7 tests.

Ticket reopened to fix the issue quickly again.

Actions #15

Updated by JERiveraMoya 24 days ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF