action #162095
openopenQA Tests - coordination #96596: [qe-core][CI] CI/CD and Coding style improvements
os-autoinst-distri-opensuse uses os-autoinst-common for perltidy
0%
Description
Motivation¶
In #155062 we moved os-autoinst to tidyall
from os-autoinst-common via a subrepo.
os-autoinst-distri-opensuse is still using tools/tidy
which is a symlink to the old tools/tidy
in the "manually" cloned os-autoinst repo as a subdirectory.
It should use the new tidyall
script by using os-autoinst-common as a subrepo or submodule.
The perltidy version should go into os-autoinst-distri-opensuse/cpanfile
directly instead of using the one from os-autoinst.
Updating the subrepo or submodule should happen via a make target.
Also it should be checked if cloning os-autoinst in os-autoinst-distri-opensuse is still necessary. make prepare
installs some perl modules from os-autoinst's cpanfile https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/Makefile#L11 but that shouldn't be needed as we have rpm packages for that.
- AC1: os-autoinst-distri-opensuse uses tidyall from os-autoinst-common and maintains its own Perl::Tidy version in cpanfile
- AC2: Cloning os-autoinst in os-autoinst-distri-opensuse is obsolete (if possible)
Suggestions¶
- If we use a subrepo, a
make subrepo-update
should simply do asubrepo clone --force
to avoid any conflicts which can sometimes happen due to a restriction of git-subrepo. Also, updates of os-autoinst-common is probably not necessary very often.- Advantage: for users the subrepo is just there, as it is a simple subdirectory in git with a special status file, so they don't need to clone any submodules
- Disadvantage: os-autoinst-common now contains quite some files and they would only be needed for development. A submodule would only clone them on request
Updated by tinita 6 months ago
- Related to coordination #154777: [saga][epic] Shareable os-autoinst and test distribution plugins added