QA » openQA Project » openQA Tests » qe-yam

MR: https://gitlab.suse.de/qe-yam/openqa-job-groups/-/merge_requests/220

hi @tinawang123 could you please use next time git revert to revert changes. This is partially reverted:
https://gitlab.suse.de/qe-yam/openqa-job-groups/-/merge_requests/228/diffs (no big deal, just that we might leave dead code accidentally doing in that way).
Additionally it would be good to have here a link to the revert for anyone following the ticket to know the state, once it is merged.
Feel free to ask for review to the team even for the revert ones or simple ones, a couple of more eyes always help with those little details.

For this ticket as we agreed, we are waiting for #161231 where we will unregister the parent and ensure fresh registration for each existing child job (to not break anything).

JERiveraMoya wrote in #note-3:

hi @tinawang123 could you please use next time git revert to revert changes. This is partially reverted:
https://gitlab.suse.de/qe-yam/openqa-job-groups/-/merge_requests/228/diffs (no big deal, just that we might leave dead code accidentally doing in that way).
Additionally it would be good to have here a link to the revert for anyone following the ticket to know the state, once it is merged.
Feel free to ask for review to the team even for the revert ones or simple ones, a couple of more eyes always help with those little details.

Hi @JERiveraMoya. I didn't use 'git revert', because I want to keep test_suites.yaml file. Because, I think our purpose is remove the failed jobs from Yast MU job group. So I removed the job migr_sles15sp3_sp5 from Yast MU job group. But I would like to keep the change at test_suites.yaml. As after the failure fixed, I can only add job to Yast MU job group.

tinawang123 wrote in #note-5:

JERiveraMoya wrote in #note-3:

hi @tinawang123 could you please use next time git revert to revert changes. This is partially reverted:
https://gitlab.suse.de/qe-yam/openqa-job-groups/-/merge_requests/228/diffs (no big deal, just that we might leave dead code accidentally doing in that way).
Additionally it would be good to have here a link to the revert for anyone following the ticket to know the state, once it is merged.
Feel free to ask for review to the team even for the revert ones or simple ones, a couple of more eyes always help with those little details.

Hi @JERiveraMoya. I didn't use 'git revert', because I want to keep test_suites.yaml file. Because, I think our purpose is remove the failed jobs from Yast MU job group. So I removed the job migr_sles15sp3_sp5 from Yast MU job group. But I would like to keep the change at test_suites.yaml. As after the failure fixed, I can only add job to Yast MU job group.

I know why you did but it is not the best practice IMO, revert should be fully, because we might miss to remember to remove code that has no use anymore (example, change of priorities and shift to another project, vacations of the person that did the change, etc). Additionally the revert is easier to review by others, but just my two cents here :)