action #134717
closedsalt-states-openqa pipeline fails because of telegraf checks
Description
Observation¶
The check for telegraf config errors is not doing what we want.
Apparently in the past the pipeline was passing although there were telegraf errors, and once all those were fixed, the pipeline started to pass, so the logic was doing the opposite.
I tried to fix it with this MR:
https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/943 (merged)
However I missed that there is an exclamation mark at the start of the telegraf command, and this is not doing what we want.
Also my test for an empty logfile didn't work because there are more lines landing in that logfile, so now I hope I fixed both issues with this MR:
https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/945
Updated by tinita over 1 year ago
- Status changed from Feedback to Resolved
It looks like it's doing the right logic now. Resolving
Updated by tinita over 1 year ago
Forgot to mention the last MR I made: https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/949