action #132950
closedcoordination #121864: [epic] Split and enhance test modules in migrations
Create new test modules for reboot_before_migration and stop_grub_timeout
Description
Motivation¶
We can try to go one small step forward refactoring recently created reboot_to_upgrade.pm
This module contains the following actions:
Requirements, they could go in a pre_run_hook.
quit_packagekit;
wait_for_purge_kernels;
Question is if leaving aside the logic for zdup we can here just do:
power_action('reboot', textmode => 1, keepconsole => 1);
assert_screen('inst-bootmenu', 300);
We don't need to use any setting and we can think for this new test modules in qemu.
In another test module we can cover:
# we need to stop_grub_timeout after grub shows up or it will boot into HDD sometimes.
# for x86_64 we need to make sure the start item is installation for needle matching.
stop_grub_timeout if is_x86_64;
save_screenshot;
but instead of using the function, we can just use send_key 'up';
and we can use other tricks for other archs in the future, but like that is visible how is done.
Acceptance criteria¶
AC1: Remove all the code that is not strictly needed for our simple case of refactoring in migrations, following suggestions above.
Additional information¶
Refactored test suite are currently in this job group with names ending on *_split_patch_sle
.
Updated by hjluo about 1 year ago
now need to clear up the PR and new VRs to review it again, now working on it after the holiday.
Updated by hjluo about 1 year ago
- Status changed from In Progress to Resolved
PR merged and close this as resolved.