Project

General

Profile

Actions

coordination #132467

open

[epic] Prevent redundant salt state.apply actions that are executed in every call

Added by okurz 10 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
2023-07-09
Due date:
% Done:

0%

Estimated time:

Description

Motivation

We manage more and more machines within our salt infrastructure https://gitlab.suse.de/openqa/salt-states-openqa so it becomes more important to make sure that the high state is applied efficiently. Normally a recurring call of salt \* state.apply should not take long and not do any changes on the system assuming that any previous call already applies all pending changes. So we should review the actions happening in recurring calls to state.apply and change all state rules accordingly so that they are really only called if necessary.

Acceptance criteria

  • AC1: No redundant repeated actions visible when calling salt \* state.apply
  • AC2: All necessary actions are still applied on the systems including scripts in /opt/openqa-trigger-from-ibs-plugin

Acceptance tests

  • AT1-1: Given being logged in to OSD When calling for i in {1..2}; do salt \* state.apply; done Then the second call applies no changes to any systems

Suggestions

  • Review all actions visible in the attached logfile redundant_salt_state_apply_calls_stdout_stripped.log and try to find better conditions, state combinations, fixes, etc. to not recurringly apply changes to systems

Files

No data to display

Actions

Also available in: Atom PDF