Actions
action #130835
closedsalt high state fails after recent merge requests in salt pillars size:M
Start date:
2023-06-14
Due date:
% Done:
0%
Estimated time:
Tags:
Description
Observation¶
https://gitlab.suse.de/openqa/salt-pillars-openqa/-/jobs/1629763 fails. From https://gitlab.suse.de/openqa/salt-pillars-openqa/-/jobs/1629763/raw
.worker3.oqa.suse.de:
Data failed to compile:
----------
Rendering SLS 'base:openqa.openvswitch' failed: Jinja error: argument of type 'StrictUndefined' is not iterable
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/salt/utils/templates.py", line 502, in render_jinja_tmpl
output = template.render(**decoded_context)
File "/usr/lib/python3.6/site-packages/jinja2/asyncsupport.py", line 76, in render
return original_render(self, *args, **kwargs)
File "/usr/lib/python3.6/site-packages/jinja2/environment.py", line 1008, in render
return self.environment.handle_exception(exc_info, True)
File "/usr/lib/python3.6/site-packages/jinja2/environment.py", line 780, in handle_exception
reraise(exc_type, exc_value, tb)
File "/usr/lib/python3.6/site-packages/jinja2/_compat.py", line 37, in reraise
raise value.with_traceback(tb)
File "<template>", line 119, in top-level template code
TypeError: argument of type 'StrictUndefined' is not iterable
; line 119
---
[...]
{% if 'bridge_ip' in remote_conf %}
{% set remote_ip=remote_conf['bridge_ip'] %}
{% elif 'bridge_iface' in remote_conf %}
{% set remote_interfaces = salt['mine.get']("nodename:" + remote, 'ip4_interfaces', tgt_type='grain').values()|list %}
{% set remote_bridge_interface = remote_conf['bridge_iface'] %}
{% if remote_bridge_interface in remote_interfaces[0] %} <======================
{% set remote_ip = remote_interfaces[0][remote_bridge_interface][0] %}
{% endif %}
{% endif %}
- ovs-vsctl --may-exist add-port $bridge gre{{- loop.index }} -- set interface gre{{- loop.index }} type=gre options:remote_ip={{ remote_ip }}
{% endfor %}
[...]
---
From ssh osd 'sudo salt --no-color --state-output=changes \* state.apply' we can reproduce that.
Suggestions¶
- Check on one worker and fix the error
- Consider improving CI checks e.g. using https://salt-lint.readthedocs.io/en/latest/
Actions