Project

General

Profile

action #123445

[tools] ShellCheck test in os-autoinst fails in CI ( on Tumbleweed )

Added by osukup 2 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Concrete Bugs
Target version:
Start date:
2023-01-20
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

In tumbleweed was released new version of ShellCheck catching new problems in scripts leading to fail in our CI:

test 4
    Start 4: test-local-shellcheck
4: Test command: /opt/tools/check-shellcheck "/usr/bin/shellcheck"
4: Working Directory: /opt
4: Test timeout computed to be: 10000000
4: 
4: In tools/container_run_ci line 33:
4:     -h | --help ) usage 0; shift ;;
4:                            ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
4: 
4: 
4: In tools/invoke-tests line 28:
4:     -h | --help               ) usage;                     shift   ;;
4:                                                            ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
4: 
4: 
4: In tools/tidy line 37:
4:     -h | --help ) usage; shift ;;
4:                          ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
4: 
4: For more information:
4:   https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
4/7 Test #4: test-local-shellcheck ............***Failed    0.18 sec

Acceptance criteria

AC1: CI passes

History

#1 Updated by osukup 2 months ago

  • Description updated (diff)

#2 Updated by osukup 2 months ago

  • Target version set to Ready

#3 Updated by jbaier_cz 2 months ago

Seems correct, there is indeed an exit in the usage function, so the shift will never be reached. That is a nice new rule.

#4 Updated by tinita 2 months ago

  • Category set to Concrete Bugs
  • Status changed from New to In Progress
  • Assignee set to tinita

#5 Updated by tinita 2 months ago

  • Status changed from In Progress to Feedback

#6 Updated by tinita 2 months ago

  • Status changed from Feedback to Resolved

merged

Also available in: Atom PDF