Actions
action #123445
closed[tools] ShellCheck test in os-autoinst fails in CI ( on Tumbleweed )
Description
In tumbleweed was released new version of ShellCheck catching new problems in scripts leading to fail in our CI:
test 4
Start 4: test-local-shellcheck
4: Test command: /opt/tools/check-shellcheck "/usr/bin/shellcheck"
4: Working Directory: /opt
4: Test timeout computed to be: 10000000
4:
4: In tools/container_run_ci line 33:
4: -h | --help ) usage 0; shift ;;
4: ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
4:
4:
4: In tools/invoke-tests line 28:
4: -h | --help ) usage; shift ;;
4: ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
4:
4:
4: In tools/tidy line 37:
4: -h | --help ) usage; shift ;;
4: ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
4:
4: For more information:
4: https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
4/7 Test #4: test-local-shellcheck ............***Failed 0.18 sec
Acceptance criteria
AC1: CI passes
Updated by jbaier_cz about 2 years ago
Seems correct, there is indeed an exit in the usage function, so the shift will never be reached. That is a nice new rule.
Updated by tinita about 2 years ago
- Category set to Regressions/Crashes
- Status changed from New to In Progress
- Assignee set to tinita
Updated by tinita about 2 years ago
- Status changed from In Progress to Feedback
Actions