Actions
action #112382
closedcoordination #90086: [epic] Refactor container tests
Don't add REGISTRY variable to insecure registry entry in docker config
Start date:
2022-06-14
Due date:
% Done:
0%
Estimated time:
Description
We need to make this section depending on if REGISTRY
variable is set.
https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/containers/docker.pm#L31
assert_script_run(
'echo "{ \"debug\": ' . $debug . ', \"insecure-registries\" : [\"localhost:5000\", \"registry.suse.de\", \"' . $registry . '\"] }" > /etc/docker/daemon.json');
This is adding $registry
regardless if REGISTRY
variable is set or not.
my $registry = registry_url();
if the REGISTRY
variable is not set, this will return docker.io
and it doesn't make sense to add docker.io
to insecure registries section.
Related: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/15074
Updated by jlausuch about 2 years ago
- Status changed from Workable to In Progress
- Assignee set to jlausuch
Updated by jlausuch about 2 years ago
Updated by jlausuch about 2 years ago
- Status changed from In Progress to Feedback
Actions