Project

General

Profile

Actions

action #109431

closed

coordination #103323: [epic] BCI testing

Split minimal and micro tests

Added by jlausuch about 2 years ago. Updated about 2 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Target version:
-
Start date:
2022-04-03
Due date:
% Done:

0%

Estimated time:

Description

Current micro and minimal images are tested in the same module:
https://gitlab.suse.de/dancermak/bci-tests/-/blob/main/tests/test_minimal.py

The idea is to split this into test_minimal.py and test_micro.py to host the specific tests for each image.

Actions #1

Updated by ph03nix about 2 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ph03nix
Actions #3

Updated by ph03nix about 2 years ago

  • Status changed from In Progress to Closed
Actions #4

Updated by ph03nix about 2 years ago

  • Status changed from Closed to In Progress
Actions #5

Updated by jlausuch about 2 years ago

Related discussion: https://suse.slack.com/archives/C02CGKBCGT1/p1652442408958179

they are similar but we still have methods like test_minimal_image_size which does the check for both, or test_rpm_absent_in_micro or test_rpm_present_in_minimal which is only relevant for 1 of the 2 images. The only “common” test is  test_fat_packages_absent

I still think the split makes sense. Duplicated code can go to test_all.py

Actions #6

Updated by ph03nix about 2 years ago

How shall we proceed on this?

Actions #7

Updated by jlausuch about 2 years ago

  • Status changed from In Progress to Rejected

Closing this one. We didn't find consensus and this is just aesthetics of the code and logic.
Maybe, when we find the need to increase the coverage of those images we can do the split.

Actions

Also available in: Atom PDF