Project

General

Profile

Actions
Copy link

action #105244

closed

retrospective outcome: Come up with best practices for creating pull requests that depend on each other

Added by okurz almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
okurz
Target version:
openQA Project - Ready
Start date:
2022-01-21
Due date:
% Done:

0%

Estimated time:

Description

Motivation

From retro 2022-01-21: Sometimes there are pull requests that are based on other pull requests. Person X reviews PR 1 and Person Y reviews PR 2, but they share the same commit. As a result we have more work for all. I want clear instructions which of the PRs are supposed to be reviewed.

Ideas

  • How about putting some keywords in the PR subject line, e.g. "Part 1/X - …"
Actions
Copy link
 #1

Updated by openqa_review almost 3 years ago

  • Due date set to 2022-02-05

Setting due date based on mean cycle time of SUSE QE Tools

Actions
Copy link
 #2

Updated by okurz almost 3 years ago

  • Due date deleted (2022-02-05)
  • Status changed from In Progress to Resolved

I tried out a new concept with keywords in the PR subject line in https://github.com/os-autoinst/openQA/pull/4473 . As tinita confirmed to be ok with the approach I noted this and other suggested practices down on https://progress.opensuse.org/projects/qa/wiki/Tools#Collaboration-best-practices

Actions
Copy link

Also available in: Atom PDF