Project

General

Profile

Actions
Copy link

action #105217

closed

deprecate and prepare removal of os-autoinst backend::amt because it is likely unused and remove if we have no significant code coverage

Added by okurz over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
okurz
Category:
Feature requests
Target version:
Ready
Start date:
2022-01-21
Due date:
% Done:

0%

Estimated time:

Description

Motivation

I conducted a poll in SUSE QE Tools workshop 2022-01-21 about if people know any test where os-autoinst backends are used and the "backend::amt" came up with 0 matches. Also on OSD I called SQL select * from machines where backend ~ 'amt'; and found no matches. Unless we have significant test code coverage we should mark the amt backend as deprecated and prepare removal because likely no one uses it and it's unlikely to work as expected.

Actions
Copy link
 #1

Updated by okurz over 2 years ago

  • Status changed from New to In Progress
  • Assignee set to okurz

https://app.codecov.io/gh/os-autoinst/os-autoinst shows that the AMT backend is not covered in tests. However it was introduced not that long ago in

commit 396a8b6d
Author: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Date:   Tue Aug 7 15:01:42 2018 +0200

I thought it might have been older. So I vote against deprecating and removing it (for now). But we can try to add tests.

Actions
Copy link
 #3

Updated by okurz over 2 years ago

  • Due date set to 2022-02-04
  • Status changed from In Progress to Feedback

PR ready. All checks passed. Waiting for review.

Actions
Copy link
 #4

Updated by okurz about 2 years ago

  • Due date deleted (2022-02-04)
  • Status changed from Feedback to Resolved

PR merged. With this amt is marked deprecated. Whenever enough time has passed and especially if the backend poses a problem for us we can remove it.

Actions
Copy link

Also available in: Atom PDF