action #175851
Updated by jbaier_cz 3 months ago
## Observation On `salt --state-output=changes -C "G@roles:worker" state.apply` the state "stop_and_disable_all_not_configured_workers" is always executed and listed as changed. For proper idempotent evaluation the state shouldn't be evaluated. ## Acceptance criteria * **AC1:** Running `state.apply` on multiple OSD hosts repeatedly shows no changed states ## Acceptance tests * **AT1-1:** Run `ssh openqa.suse.de "sudo nice env runs=30 count-fail-ratio salt --state-output=changes -C '*' state.apply queue=True | grep -v 'Result.*Clean"` and look for "Succeeded: $big_number" without "(changed=1)" ## Suggestions * Look into the already existing "unless" in https://gitlab.suse.de/openqa/salt-states-openqa/-/blob/master/openqa/worker.sls?ref_type=heads#L220 https://gitlab.suse.de/openqa/salt-states-openqa/-/blob/master/openqa/worker.sls?ref_type=heads#L225 and figure out what broke. Maybe related to "masked instances"?