action #132689
Updated by livdywan 8 months ago
[qem-dashboard] Incorrect behavior for Group Flavor feature ## Observation Blocked by Tests [view](http://dashboard.qam.suse.de/blocked) show incorrect results when Group Flavor is toggled on (the default). In some cases, the flavors with errors are hidden. See the attached pictures of the same incident with Grouped Flavors off and on. * From Updated by mgrifalconi 1 day ago Priority changed from Normal to High Hello, now the issue is still present but it become worse as you are not able to 'ungroup flavors' anymore (maybe a regression caused by the new feature of having search parameters in the url?) Clicking the "group flavor" checkbox now does nothing. One example is http://dashboard.qam.suse.de/incident/30825 (filter out 30825 in blocked page) where you see no red boxes on SLE Micro (link of green box is https://openqa.suse.de/tests/overview?build=20231003-1&distri=sle-micro&groupid=420&version=5.5&flavor=Default-Updates) but opening the link of the incident you can see the failures: https://openqa.suse.de/tests/overview?version=5.5&groupid=420&flavor=Default-RT-SelfInstall-Updates&distri=sle-micro&build=20231003-1 Proposing a higher prio here since it completely hides failures now with no workaround (other than clicking every single incident) * Updated by mkittler about 20 hours ago Clicking the "group flavor" checkbox now does nothing. I was under the same impression after https://github.com/openSUSE/qem-dashboard/pull/359 had been deployed. However, it turned out that the current dataset simply didn't have anything that could be grouped. I have also cross-checked by importing an older production database dump locally. This dataset still had groupable entries and the grouping still worked after my change. So I don't think that "group flavor" doing nothing is related to my change - it is simply because there's nothing to group. I'm not sure whether I can follow further paragraphs in your comment. You mention a few links but none of those is about the http://dashboard.qam.suse.de/blocked page the "Group flavor" feature is about. (Note that "Group flavor" is only supposed to group by the flavor if the distribution and version are identical as well. After a quick look on http://dashboard.qam.suse.de/blocked I couldn't find such an instance.) ## Acceptance criteria * **AC1:** Both views (grouped or not) provides correct (i.e. the same) information * **AC2**: Failures are visible in both views * **AC3**: Counts add up between the grouped and ungrouped view ## Suggestions * Import the database dump to reproduce locally * Inspect the logic behind "Group Flavor" * For local testing data try the database dump from `/home/lurklur/bug-poo-132689.sql.xz` on qam2.suse.de, reproduce the failed red box not showing up based on grouping selection as visible in screenshots, fix the displaying so that a failed red box with corresponding entries show up in both cases grouped and not-grouped * Make a test case for the failing case