action #94994
Updated by livdywan almost 3 years ago
The salt-minion on machines like backup.qa.suse.de contains quite some tracebacks - even though it doesn't seem to crash. ``` Jul 01 14:33:34 backup-vm systemd[1]: Started The Salt Minion. Jul 01 14:33:36 backup-vm salt-minion[2390]: [CRITICAL] Failed to load grains defined in grain file default_interface.default_interface in function <function default_interface at 0x7fa1e9a4b598>, error: Jul 01 14:33:36 backup-vm salt-minion[2390]: Traceback (most recent call last): Jul 01 14:33:36 backup-vm salt-minion[2390]: File "/usr/lib/python3.6/site-packages/salt/loader.py", line 853, in grains Jul 01 14:33:36 backup-vm salt-minion[2390]: ret = funcs[key](**kwargs) Jul 01 14:33:36 backup-vm salt-minion[2390]: File "/var/cache/salt/minion/extmods/grains/default_interface.py", line 10, in default_interface Jul 01 14:33:36 backup-vm salt-minion[2390]: internalip = salt.modules.network.ip_addrs(cidr='10.160.0.0/13')[0] Jul 01 14:33:36 backup-vm salt-minion[2390]: File "/usr/lib/python3.6/site-packages/salt/modules/network.py", line 1278, in ip_addrs Jul 01 14:33:36 backup-vm salt-minion[2390]: addrs = __utils__["network.ip_addrs"]( Jul 01 14:33:36 backup-vm salt-minion[2390]: NameError: name '__utils__' is not defined Jul 01 14:33:36 backup-vm salt-minion[2390]: [CRITICAL] Failed to load grains defined in grain file ppc_powervm.check_output in function <function check_output at 0x7fa1fae79730>, error: Jul 01 14:33:36 backup-vm salt-minion[2390]: Traceback (most recent call last): Jul 01 14:33:36 backup-vm salt-minion[2390]: File "/usr/lib/python3.6/site-packages/salt/loader.py", line 853, in grains Jul 01 14:33:36 backup-vm salt-minion[2390]: ret = funcs[key](**kwargs) Jul 01 14:33:36 backup-vm salt-minion[2390]: File "/usr/lib64/python3.6/subprocess.py", line 356, in check_output Jul 01 14:33:36 backup-vm salt-minion[2390]: **kwargs).stdout Jul 01 14:33:36 backup-vm salt-minion[2390]: File "/usr/lib64/python3.6/subprocess.py", line 423, in run Jul 01 14:33:36 backup-vm salt-minion[2390]: with Popen(*popenargs, **kwargs) as process: Jul 01 14:33:36 backup-vm salt-minion[2390]: TypeError: __init__() missing 1 required positional argument: 'args' Jul 01 14:33:41 backup-vm salt-minion[2390]: [CRITICAL] Failed to load grains defined in grain file default_interface.default_interface in function <function default_interface at 0x7fa1e9a4b840>, error: Jul 01 14:33:41 backup-vm salt-minion[2390]: Traceback (most recent call last): Jul 01 14:33:41 backup-vm salt-minion[2390]: File "/usr/lib/python3.6/site-packages/salt/loader.py", line 853, in grains Jul 01 14:33:41 backup-vm salt-minion[2390]: ret = funcs[key](**kwargs) Jul 01 14:33:41 backup-vm salt-minion[2390]: File "/var/cache/salt/minion/extmods/grains/default_interface.py", line 10, in default_interface Jul 01 14:33:41 backup-vm salt-minion[2390]: internalip = salt.modules.network.ip_addrs(cidr='10.160.0.0/13')[0] Jul 01 14:33:41 backup-vm salt-minion[2390]: File "/usr/lib/python3.6/site-packages/salt/modules/network.py", line 1278, in ip_addrs Jul 01 14:33:41 backup-vm salt-minion[2390]: addrs = __utils__["network.ip_addrs"]( Jul 01 14:33:41 backup-vm salt-minion[2390]: NameError: name '__utils__' is not defined Jul 01 14:33:41 backup-vm salt-minion[2390]: [CRITICAL] Failed to load grains defined in grain file ppc_powervm.check_output in function <function check_output at 0x7fa1fae79730>, error: Jul 01 14:33:41 backup-vm salt-minion[2390]: Traceback (most recent call last): Jul 01 14:33:41 backup-vm salt-minion[2390]: File "/usr/lib/python3.6/site-packages/salt/loader.py", line 853, in grains Jul 01 14:33:41 backup-vm salt-minion[2390]: ret = funcs[key](**kwargs) Jul 01 14:33:41 backup-vm salt-minion[2390]: File "/usr/lib64/python3.6/subprocess.py", line 356, in check_output Jul 01 14:33:41 backup-vm salt-minion[2390]: **kwargs).stdout Jul 01 14:33:41 backup-vm salt-minion[2390]: File "/usr/lib64/python3.6/subprocess.py", line 423, in run Jul 01 14:33:41 backup-vm salt-minion[2390]: with Popen(*popenargs, **kwargs) as process: Jul 01 14:33:41 backup-vm salt-minion[2390]: TypeError: __init__() missing 1 required positional argument: 'args' ``` # Suggestions * Investigate the cause of these this errors * Focus on fixing our salt minion code in https://gitlab.suse.de/openqa/salt-pillars-openqa # Acceptance Criteria * **AC1**: No critical errors or exceptions in salt minion # Acceptance tests * **AT1**: Run `sudo salt \* cmd.run 'grep CRITICAL /var/log/salt/minion'` on osd We know if this is a problem for us and if there is anything we can do about this