Project

General

Profile

action #93677

Updated by osukup almost 3 years ago

## Observation 

 https://app.circleci.com/pipelines/github/os-autoinst/openQA/6619/workflows/f6ed6d22-8098-4e01-8a8d-4b3b4509954f/jobs/62263?invite=true#step-111-86 shows 

 ``` 
 RETRY=0 timeout -s SIGINT -k 5 -v $((9 * (0 + 1) ))m tools/retry prove -l --harness TAP::Harness::JUnit --timer t/full-stack.t 
 [15:32:02] t/full-stack.t .. 25/? timeout: sending signal INT to command ‘tools/retry’ 
 make[2]: *** [Makefile:188: test-unit-and-integration] Error 124 
 ``` 

 so the overall test run is aborted on the level of Makefile after 9m. That means that t/full-stack.t was stuck for that time and also the test module internal timeout in https://github.com/os-autoinst/openQA/blob/master/t/full-stack.t#L59 of 90s with a scaling factor exceeds the 9m. Default scaling from external/os-autoinst-common/lib/OpenQA/Test/TimeLimit.pm is 3*2 so computing to 3*2*90s = 540s ~ 9m conflicting with the makefile time limit 

 ## Acceptance criteria 
 * **AC1:** Time-based stability of full-stack test is confirmed 
 * **AC2:** test module internal timeout is well below make-level timeout also in case of CI+cover 

 ## Suggestions 
 * Check time-based stability of full-stack test locally, e.g. with `make test FULLSTACK=1 STABILITY_TEST=1 RETRY=10 KEEP_DB=1 TESTS=t/full-stack.t` 
 * Bump timeout in Makefile

Back