Project

General

Profile

action #94354

Updated by tinita over 3 years ago

On the homepage and group_overview pages `comment_data_for_jobs` is called. It collects bugrefs and fetches all bugs, but in those views we don't even show this data. 
 Also, all columns of Comments are selected, while only two are needed. 

 I looked into this while working on #93925 
 I already did a fix, so even if this is not a high priority, it's already done, and an easy fix. So i took the liberty to create this ticket and a PR. 

 ``` 
 Runtime before: 
 /group_overview/1: 1.0-1.1s 
 /dashboard_build_results: 0.9-0.95s 
 Runtime after: 
 /group_overview/1: 0.8-0.85s 
 /dashboard_build_results: 0.75-0.77s 
 ``` 

 SQL statements which will be saved: 
 ``` 
 SELECT me.id, me.bugid, me.title, me.priority, me.assigned, me.assignee, me.open, me.status, me.resolution, me.existing, me.refreshed, me.t_created, me.t_updated FROM bugs me WHERE ( me.bugid = ? ): 'boo#1183454' 
 SELECT me.id, me.bugid, me.title, me.priority, me.assigned, me.assignee, me.open, me.status, me.resolution, me.existing, me.refreshed, me.t_created, me.t_updated FROM bugs me WHERE ( me.bugid = ? ): 'poo#92945' 
 SELECT me.id, me.bugid, me.title, me.priority, me.assigned, me.assignee, me.open, me.status, me.resolution, me.existing, me.refreshed, me.t_created, me.t_updated FROM bugs me WHERE ( me.bugid = ? ): 'poo#92401' 
 SELECT me.id, me.bugid, me.title, me.priority, me.assigned, me.assignee, me.open, me.status, me.resolution, me.existing, me.refreshed, me.t_created, me.t_updated FROM bugs me WHERE ( me.bugid = ? ): 'boo#1180358' 
 # and so on 
 ``` 
 for each build

Back