action #70918: gitlab pillar merge requests try to execute CI tests and fail because tests from states are not compatible - openQA Infrastructure (public) - openSUSE Project Management Tool

Actions

Copy link

action #70918

closed

gitlab pillar merge requests try to execute CI tests and fail because tests from states are not compatible

Added by okurz over 4 years ago. Updated over 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

okurz

Category:

Target version:

openQA Project (public) - Ready

Start date:

2020-09-03

Due date:

% Done:

Estimated time:

Description

See https://gitlab.suse.de/MMoese/salt-pillars-openqa/-/jobs/252823#L52

Problem is the pipeline fails because of https://gitlab.suse.de/MMoese/salt-pillars-openqa/-/jobs/252823#L58 being called in the top folder of the pillar repo. So salt tries to read the pillar data as a complete state tree but pillars are not the complete tree. also see https://gitlab.suse.de/MMoese/salt-pillars-openqa/-/jobs/252823#L52 ? We clone pillars from master into a subfolder. This makes sense when one wants to test a MR for states. For that we use pillar from master. But of course for testing pillar data that does not make sense. We would need to checkout states from its master in parallel and point to the pillar data from the MR but still call salt on the states top file. so in short: Currently calling tests from the states repo within the pillar data is not supported and should not be done, the deploy is independant and works for both. see https://gitlab.suse.de/openqa/salt-states-openqa/-/blob/master/.gitlab-ci.yml#L27 . we exclude the tests already for master@openqa/salt-pillars-openqa but not for any fork repo