tickets #178120
closedman.infra.o.o: changes to rsyncd.conf have wrong syntax
0%
Description
The change to rsyncd.conf to exclude Leap-* were wrong. The resulting line in rsyncd.conf is currently:
exclude = google897e15adbab60af5.html, Leap-
Correct would be:
exclude = google897e15adbab60af5.html Leap-*
The list is space separated, not comma separated. And the "*" is missing.
As result a lot of data got deleted including the one for the google search.
Updated by crameleon about 2 months ago
- Category set to Manpages (service)
- Status changed from New to In Progress
- Assignee set to crameleon
- Private changed from Yes to No
I don't see a "*" mentioned in https://progress.opensuse.org/issues/178030, and I just copied from there? Submitted https://gitlab.infra.opensuse.org/infra/salt/-/merge_requests/2359 for you, but I think with the previous patch as an example you could also have submitted that yourself. :-)
Updated by crameleon about 2 months ago
I think I see what happened there, * without code formatting gets turned into cursive.
Updated by crameleon about 2 months ago
- Status changed from In Progress to Resolved
Updated by kukuk about 2 months ago
- Status changed from Resolved to New
Thanks, but the fix is not complete: The Leap-* is done, but the list is still comma separated and not white space.
This means salt creates google897e15adbab60af5.html, and the google897e15adbab60af5.html file get's still deleted.
Updated by crameleon about 2 months ago
My bad, that's unfortunate some parameters according to the manual take "a list of comma- and/or whitespace-separated patterns" and some only "a space-separated list", I made https://github.com/openSUSE/salt-formulas/pull/227 (if my search is correct, that should work for all parameters which take a list universally).
Updated by crameleon about 2 months ago
Adjusted it manually on the machine in the meanwhile and will wait with the next apply.