Project

General

Profile

Actions
Copy link

action #156775

closed

cpanspec should adopt new %patch syntax size:S

Added by tinita 9 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Low
Assignee:
tinita
Target version:
openQA Project - Ready
Start date:
2024-03-06
Due date:
% Done:

0%

Estimated time:
Tags:
reactive work

Description

Motivation

https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/YNXIWWHY7E2ZDMLKL44K7RR4Y2LCDV45/

%patchN is deprecated and should be replaced with %patch -PN.
In cpanspec we are using %autosetup if possible, but otherwise we still use %patchN.

Acceptance criteria

  • AC1: Perl packages in Factory (especially openQA ones) continue to build after the RPM change

Acceptance tests

  • AT1-1: Given RPM 4.20 is available all packages in devel:languages:perl still build without an error related to (at least) %patchN

Suggestions

  • Check all packages in devel:languages:perl to ensure that they don't use %patchN
  • Look into https://github.com/openSUSE/cpanspec/blob/master/cpanspec#L1356-L1358 and adapt/extend to use explicit %patch -PN instead
  • Ensure all packages devel:languages:perl use that, e.g. with individual batch creation of submit requests. Possibly most are done already or don't rely on %patch
  • Ensure that all submit requests are accepted and also forwarded into openSUSE:Factory accordingly
  • Crosscheck with scripting that no packages are left in d:l:p (and possibly openSUSE:Factory) using %patchN

Out of scope

  • Ignore devel:languages:perl:CPAN-[A-Z] as they would be only updated on new releases on CPAN but we don't care because those are not accepted (yet) into devel:languages:perl
Actions
Copy link
 #1

Updated by okurz 9 months ago

  • Tags set to reactive work
Actions
Copy link
 #2

Updated by okurz 9 months ago

  • Priority changed from Normal to Low
Actions
Copy link
 #3

Updated by okurz 9 months ago

  • Subject changed from cpanspec should adapt to new %patch syntax to cpanspec should adopt new %patch syntax size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #4

Updated by tinita 9 months ago

  • Assignee set to tinita
Actions
Copy link
 #5

Updated by tinita 9 months ago

https://github.com/openSUSE/cpanspec/pull/50 Adapt %patch syntax for rpm 4.20 release

Actions
Copy link
 #6

Updated by tinita 9 months ago ยท Edited

I fixed 40 modules in https://build.opensuse.org/project/show/devel:languages:perl that were still using %patchN (none of them in Factory; those were already handled by someone else).
5 have unrelated failures or unresolvable dependencies that I couldn't fix.
https://build.opensuse.org/project/requests/devel:languages:perl

Actions
Copy link
 #7

Updated by tinita 8 months ago

  • Status changed from Workable to Resolved

All SR accepted

Actions
Copy link

Also available in: Atom PDF