action #105370
closedhttps://openqa.opensuse.org/tests/2150931#next_previous as well as the according /tests/overview page shows a comment, should show a label icon size:M
Description
Observation¶
https://openqa.opensuse.org/tests/2150931#next_previous as well as the according /tests/overview page shows a comment icon instead of a label icon
Acceptance criteria¶
- AC1: Next/previous reflects labels with a label icon
Suggestions¶
- Confirm if this could be a regression from schema changes in https://github.com/os-autoinst/openQA/pull/4458/commits/5c9a138ceb6dbf5492bb69ec6f71e77a73aa0869
- Ensure javascript and Perl implementations behave the same
Updated by livdywan over 2 years ago
- Subject changed from https://openqa.opensuse.org/tests/2150931#next_previous as well as the according /tests/overview page shows a comment, should show a label icon to https://openqa.opensuse.org/tests/2150931#next_previous as well as the according /tests/overview page shows a comment, should show a label icon size:M
- Description updated (diff)
- Status changed from New to Workable
Updated by openqa_review about 2 years ago
- Due date set to 2022-03-09
Setting due date based on mean cycle time of SUSE QE Tools
Updated by livdywan about 2 years ago
Brought up in the unblock. Why are we still confused on what the goal of the ticket is?
- https://github.com/os-autoinst/openQA/pull/4458/commits/5c9a138ceb6dbf5492bb69ec6f71e77a73aa0869 Could be read to preclude what the AC ask for. But apparently that wasn't the intention of the author.
- We have no record of working examples vs non-working examples to disambiguate/ AT
- There's no comment confirming what Moritz was going to implement as per discussion on Jitsi
Updated by okurz about 2 years ago
On top of that we clarified within the daily or unblock of 2022-02-23: We agreed that we have a regression and as stated in the description the assumption since #105370#note-1 is still true. https://github.com/os-autoinst/openQA/pull/4458/commits/5c9a138ceb6dbf5492bb69ec6f71e77a73aa0869 causes this unintended behaviour. Fix that!
Updated by kodymo about 2 years ago
This is essentiallly just a small line change, should I just remove the Regex that specifically excludes force_label from being shown as a label?
Updated by okurz about 2 years ago
as discussed this will likely not be that easy. Feel free to change a single line and execute a test in https://github.com/os-autoinst/openQA/pull/4458/commits/5c9a138ceb6dbf5492bb69ec6f71e77a73aa0869#diff-e39dc601fe37b060cdfa75edfbafee3824d347e84cbbab2a928c7b6be6160520R94
I also suggested to add a test for the current behaviour first.
Updated by tinita about 2 years ago
- Status changed from In Progress to Feedback
PR was merged https://github.com/os-autoinst/openQA/pull/4530
Updated by kodymo about 2 years ago
The job above shows a label as expected now, setting this to resolved.