Actions
action #10132
closed[functional][u] "wait_screen_change" return value should not be silently ignored
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Enhancement to existing tests
Target version:
Start date:
2016-01-07
Due date:
% Done:
0%
Estimated time:
Difficulty:
Description
Observation¶
https://openqa.suse.de/tests/175675 fails because the machine was heavily loaded causing "wait_screen_change" to timeout after 10 seconds where the return value was silently ignored, see:
https://openqa.suse.de/tests/175675/file/autoinst-log.txt
acceptance criteria¶
- wait_screen_change makes test die if screen does not change during timeout
problem¶
https://github.com/os-autoinst/os-autoinst-distri-opensuse/search?utf8=%E2%9C%93&q=wait_screen_change shows that wait_screen_change has a return value which is sometimes ignored, sometimes properly parsed. "wait_screen_change" should probably die on timeout without the need for explicit return value checking
suggestion¶
- move return value check into wait_screen_change. If code relies on wait_screen_change timing out the code should be reworked accordingly, e.g. using another method.
- check if we can disallow ignoring return value everywhere in "os-autoinst" space, e.g. by a proper style check
Actions