https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842021-04-28T17:25:19ZopenSUSE Project Management ToolopenQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4018802021-04-28T17:25:19Zokurzokurz@suse.com
<ul><li><strong>Parent task</strong> changed from <i>#91467</i> to <i>#91914</i></li></ul> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4095502021-05-21T15:36:20Zokurzokurz@suse.com
<ul><li><strong>Target version</strong> changed from <i>future</i> to <i>Ready</i></li></ul> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4115942021-05-31T06:58:05Zilausuchilausuch@suse.com
<ul><li><strong>Assignee</strong> set to <i>ilausuch</i></li></ul> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4117142021-05-31T10:26:40Zilausuchilausuch@suse.com
<ul></ul><p>I checked that we have a way to extract the last build for every job_group</p>
<pre><code class="text syntaxhl" data-language="text">SELECT distinct(group_id), FIRST_VALUE(build) over (partition by group_id order by t_created DESC) FROM jobs WHERE group_id in (1,3);
</code></pre> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4117202021-05-31T10:47:28Zilausuchilausuch@suse.com
<ul></ul><p>To have a note, in our code </p>
<ul>
<li>the query is generated here <a href="https://github.com/os-autoinst/openQA/blob/577b4d3e1011846fb645c04cf611dfe0a7e9afb0/lib/OpenQA/BuildResults.pm#L152" class="external">https://github.com/os-autoinst/openQA/blob/577b4d3e1011846fb645c04cf611dfe0a7e9afb0/lib/OpenQA/BuildResults.pm#L152</a></li>
<li>the visualization template is here <a href="https://github.com/os-autoinst/openQA/blob/master/templates/webapi/test/overview.html.ep" class="external">https://github.com/os-autoinst/openQA/blob/master/templates/webapi/test/overview.html.ep</a></li>
<li>The data processor <a href="https://github.com/os-autoinst/openQA/blob/577b4d3e1011846fb645c04cf611dfe0a7e9afb0/lib/OpenQA/WebAPI/Controller/Test.pm#L646" class="external">https://github.com/os-autoinst/openQA/blob/577b4d3e1011846fb645c04cf611dfe0a7e9afb0/lib/OpenQA/WebAPI/Controller/Test.pm#L646</a></li>
</ul>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4117712021-05-31T13:19:22Zmkittlermarius.kittler@suse.com
<ul></ul><p><del>The query in <code>BuildResults.pm</code> is for the "dashboard", that's the index page and group pages. This ticket is about the "test results overview" which has nothing to do with it. Its <em>controller</em> is the function <code>overview</code> within <code>Test.pm</code> (which you've called "data processor", not sure what you mean by that). Btw, I'm usually having a look at <code>WebAPI.pm</code> to check which route is handled where.</del> Ah, I guess I now get it. You mean the links to the test results overview which are present on the dashboard are generated by code in <code>BuuildResults.pm</code>. Not sure whether/how we should alter links on the dashboard for this, though.</p>
<p>It might be a bit tricky to convince DBIx to do a query like the one you've mentioned but rewriting the code to use a native SQL query is possibly also quite an effort because there's already lots of code which is using the DBIx result object.</p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4119362021-06-01T07:46:43Zilausuchilausuch@suse.com
<ul></ul><p>Yes, I agree with you.<br>
I am exploring an other option is to split the query (that contains different groupsid) and merge the results later<br>
<a href="https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/WebAPI/Controller/Test.pm#L646" class="external">https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/WebAPI/Controller/Test.pm#L646</a></p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4119542021-06-01T08:05:45Zilausuchilausuch@suse.com
<ul></ul><p>Regarding that,</p>
<p>When a only group is selected, the $search_args used in the query shows </p>
<pre><code>{
'groupids' => [
60
],
'scope' => 'current',
'build' => 'GM',
'groupid' => 60
}
</code></pre>
<p>and for more than one group</p>
<pre><code>{
'scope' => 'current',
'build' => '20210507',
'groupids' => [
1,
60
],
'groupid' => 1
}
</code></pre>
<p>We can see that the function compose_job_overview_search_args is filling the scope, build and groupid of the first group we select. </p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4119572021-06-01T08:05:53Zilausuchilausuch@suse.com
<ul><li><strong>Status</strong> changed from <i>Workable</i> to <i>In Progress</i></li></ul> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4120532021-06-01T09:40:41Zilausuchilausuch@suse.com
<ul></ul><p>The function compose_job_overview_search_args is implemented here<br>
<a href="https://github.com/os-autoinst/openQA/blob/3dbc437d2627aec121ce305b9f7cf41a6f4a7067/lib/OpenQA/WebAPI/Plugin/Helpers.pm#L349" class="external">https://github.com/os-autoinst/openQA/blob/3dbc437d2627aec121ce305b9f7cf41a6f4a7067/lib/OpenQA/WebAPI/Plugin/Helpers.pm#L349</a></p>
<p>And we can see how the groupid and the build is filled<br>
<a href="https://github.com/os-autoinst/openQA/blob/3dbc437d2627aec121ce305b9f7cf41a6f4a7067/lib/OpenQA/WebAPI/Plugin/Helpers.pm#L387" class="external">https://github.com/os-autoinst/openQA/blob/3dbc437d2627aec121ce305b9f7cf41a6f4a7067/lib/OpenQA/WebAPI/Plugin/Helpers.pm#L387</a></p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4121432021-06-01T11:06:18Zilausuchilausuch@suse.com
<ul></ul><p>Trying to do an approach here <a href="https://github.com/os-autoinst/openQA/pull/3925" class="external">https://github.com/os-autoinst/openQA/pull/3925</a>.<br>
Disclaimer: this doesn't work yet, is still a draft</p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4125302021-06-02T06:00:10Zopenqa_reviewopenqa-review@suse.de
<ul><li><strong>Due date</strong> set to <i>2021-06-16</i></li></ul><p>Setting due date based on mean cycle time of SUSE QE Tools</p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4125932021-06-02T07:16:55Zilausuchilausuch@suse.com
<ul></ul><p>I started a new approach<br>
<a href="https://github.com/os-autoinst/openQA/pull/3928" class="external">https://github.com/os-autoinst/openQA/pull/3928</a></p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4152702021-06-10T15:19:24Zilausuchilausuch@suse.com
<ul><li><strong>File</strong> <i>openQA Test summary.html</i> added</li></ul><p><a href="http://localhost:9526/tests/overview?distri=sle&version=15-SP3&arch=x86_64&build=187.1&groupid=110" class="external">http://localhost:9526/tests/overview?distri=sle&version=15-SP3&arch=x86_64&build=187.1&groupid=110</a></p>
<ul>
<li>Flavor: Migration-from-SLE11-SP4</li>
<li>Flavor: Migration-from-SLE12-SPx</li>
<li>Flavor: Migration-from-SLE15-SPx</li>
</ul>
<p><a href="http://localhost:9526/tests/overview?distri=sle&version=15-SP3&arch=x86_64&build=187.1&groupid=110" class="external">http://localhost:9526/tests/overview?distri=sle&version=15-SP3&arch=x86_64&build=187.1&groupid=110</a></p>
<ul>
<li>Flavor: Full</li>
<li>Flavor: Online</li>
</ul>
<p>With the selecction of both groupid return the addition of both groupid's<br>
<a href="http://localhost:9526/tests/overview?distri=sle&version=15-SP3&arch=x86_64&build=187.1&groupid=110&groupid=265" class="external">http://localhost:9526/tests/overview?distri=sle&version=15-SP3&arch=x86_64&build=187.1&groupid=110&groupid=265</a></p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4153062021-06-10T18:18:12Zokurzokurz@suse.com
<ul><li><strong>File</strong> deleted (<del><i>openQA Test summary.html</i></del>)</li></ul> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4153092021-06-10T18:19:13Zokurzokurz@suse.com
<ul></ul><p><a class="user active user-mention" href="https://progress.opensuse.org/users/34361">@ilausuch</a> I have deleted the attachment as it might include sensitive internal data. I suggest if possible to use data from openqa.opensuse.org for demonstration purposes as all the relevant data from there is already public so we don't have a problem to share that.</p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4156902021-06-11T11:56:25Zilausuchilausuch@suse.com
<ul></ul><p>Ok, sorry</p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4174992021-06-18T08:22:08Zilausuchilausuch@suse.com
<ul><li><strong>File</strong> <a href="/attachments/11539">example_groupids.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/11539/example_groupids.png">example_groupids.png</a> added</li></ul><p>This is solved with <a href="https://github.com/os-autoinst/openQA/pull/3918" class="external">https://github.com/os-autoinst/openQA/pull/3918</a><br>
I provide a visual example</p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4175082021-06-18T08:26:19Zilausuchilausuch@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>We have already a test for multiple group ids<br>
<a href="https://github.com/os-autoinst/openQA/blob/a6560e42378e7ac43c70d4d444ab9cd9921e2a67/t/10-tests_overview.t#L223" class="external">https://github.com/os-autoinst/openQA/blob/a6560e42378e7ac43c70d4d444ab9cd9921e2a67/t/10-tests_overview.t#L223</a><br>
So I think this ticket is complete (with Oliver's finals help)</p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4175412021-06-18T09:01:14Zilausuchilausuch@suse.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>In Progress</i></li></ul> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4179972021-06-21T06:11:09Zilausuchilausuch@suse.com
<ul></ul><p>I identified a case where doesn't work using only <a href="https://github.com/os-autoinst/openQA/pull/3918" class="external">https://github.com/os-autoinst/openQA/pull/3918</a></p>
<pre><code class="text syntaxhl" data-language="text">http://localhost:9526/tests/overview?groupid=198&groupid=287
</code></pre> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4182762021-06-21T10:28:40Zilausuchilausuch@suse.com
<ul></ul><p>Updated: The problem is that the query is only going to show the jobs for only one build. Then if the groupsid we choose has different builds only will be selected one of them.<br>
the problem is in _compose_job_overview_search_args(Helpers.pm) that takes the last_build for the first group_id</p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4196292021-06-23T12:05:09Zlivdywanliv.dywan@suse.com
<ul><li><strong>Due date</strong> changed from <i>2021-06-16</i> to <i>2021-06-18</i></li></ul><p><a href="https://github.com/os-autoinst/openQA/pull/3971" class="external">https://github.com/os-autoinst/openQA/pull/3971</a></p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4196322021-06-23T12:05:22Zlivdywanliv.dywan@suse.com
<ul><li><strong>Due date</strong> changed from <i>2021-06-18</i> to <i>2021-06-25</i></li></ul> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4197402021-06-23T15:16:54Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>replacement PR <a href="https://github.com/os-autoinst/openQA/pull/3973" class="external">https://github.com/os-autoinst/openQA/pull/3973</a> , merged. I waited until the package was built and manually deployed it so that we can immediately verify it on o3. <a href="https://openqa.opensuse.org/tests/overview?groupid=81&groupid=70" class="external">https://openqa.opensuse.org/tests/overview?groupid=81&groupid=70</a> shows how two results from two independent builds ":16451:lsb.1623764292,:16590:prometheus-ha_cluster_exporter.1624456142" show up.</p>
openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4204752021-06-25T13:22:54Zokurzokurz@suse.com
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-4 status-3 priority-5 priority-high3 closed child" href="/issues/94732">action #94732</a>: Provide link to /tests/overview of latest builds of all job groups within a parent job group size:M</i> added</li></ul> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4213092021-06-28T17:12:17Zlivdywanliv.dywan@suse.com
<ul><li><strong>Due date</strong> deleted (<del><i>2021-06-25</i></del>)</li></ul> openQA Project - action #91650: Resolve the most recent builds per job group on /tests/overview when showing multiple job groupshttps://progress.opensuse.org/issues/91650?journal_id=4285572021-07-19T12:15:38Zokurzokurz@suse.com
<ul><li><strong>Parent task</strong> changed from <i>#91914</i> to <i>#91467</i></li></ul>