Project

General

Profile

Actions
Copy link

action #88612

closed

Beautify the output of error when errors found during AutoYaST profile validation

Added by oorlov about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
JERiveraMoya
Target version:
SUSE QA - SLE 15 SP3
Start date:
2021-02-15
Due date:
% Done:

0%

Estimated time:

Description

Motivation

Currently, error output in validate_autoyast_profile function is shown without readable separation between errors and list of executed queries. So that it is not so easy to get what is wrong by just looking in autoinst-log.txt

Please see the current_not_formatted.png screenshot for how it looks.

If format the output, then it is easy to read and clarify what is wrong. Please see the how_looks_formatted.png screenshot for how it looks when formatted.

Task

Beautify the output of errors found during AutoYaST profile validation, so that it is easy to determine of what is wrong.
Assumption: it can be simply made by replacing "\n" characters in the string with the actual 'new line' character (this is what I actually did when got the formatted output).

Further info

We could use data we have in yaml to show in the output which node we have expected and also print xpath for debugging the test, in case there is an issue with this part.
We already upload autoyast profile, so we can skip printing parts of the generated xml.

Files

Download all files
how_looks_formatted.png (120 KB) how_looks_formatted.png oorlov, 2021-02-15 13:35
current_not_formatted.png (217 KB) current_not_formatted.png oorlov, 2021-02-15 13:35
Actions
Copy link
 #2

Updated by oorlov about 3 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by riafarov about 3 years ago

  • Target version set to SLE 15 SP3
Actions
Copy link
 #4

Updated by riafarov about 3 years ago

  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #5

Updated by JERiveraMoya about 3 years ago

  • Status changed from Workable to In Progress
  • Assignee set to JERiveraMoya
Actions
Copy link
 #6

Updated by JERiveraMoya about 3 years ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #7

Updated by JERiveraMoya about 3 years ago

A bit of beautification was added in #88606, as agreed I left on feedback.

Actions
Copy link
 #8

Updated by JERiveraMoya about 3 years ago

VR: osd | o3

Actions
Copy link
 #9

Updated by JERiveraMoya about 3 years ago

  • Status changed from Feedback to Closed
Actions
Copy link
 #10

Updated by JERiveraMoya about 3 years ago

  • Status changed from Closed to Feedback
Actions
Copy link
 #11

Updated by JERiveraMoya about 3 years ago

Agreed to leave it in feedback for a while so we can evaluate if needed more 'beautification' after tasks for unit testing/documentation have been completed.

Actions
Copy link
 #12

Updated by JERiveraMoya about 3 years ago

  • Status changed from Feedback to Closed

documentation added in #89539

Actions
Copy link

Also available in: Atom PDF