https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842020-10-29T08:32:48ZopenSUSE Project Management ToolopenQA Project - action #76741: help popup next to "Submit comment" does not work anymorehttps://progress.opensuse.org/issues/76741?journal_id=3445212020-10-29T08:32:48ZXiaojing_liuxliu1@suse.com
<ul></ul><p>when the javascript function <code>setupForAll</code> in openqa.js is called to add events to help popup, this help popup does not exist. The comments page is loaded by using <code>data-src="<%= url_for('test_comments', testid => $testid)</code>.<br>
I only find one solution: load the <code>add_comment_form_groups.html.ep</code> first, the comments can be got using <code>ajax</code> when clicking the tab. <br>
Can we init this help popup after loading the whole comment page (do not need to change the template code)? I do not know how to do that.</p>
openQA Project - action #76741: help popup next to "Submit comment" does not work anymorehttps://progress.opensuse.org/issues/76741?journal_id=3445812020-10-29T09:37:23Zmkittlermarius.kittler@suse.com
<ul><li><strong>Assignee</strong> set to <i>mkittler</i></li></ul> openQA Project - action #76741: help popup next to "Submit comment" does not work anymorehttps://progress.opensuse.org/issues/76741?journal_id=3445932020-10-29T09:49:00Zmkittlermarius.kittler@suse.com
<ul><li><strong>Status</strong> changed from <i>Workable</i> to <i>In Progress</i></li></ul><blockquote>
<p>Can we init this help popup after loading the whole comment page (do not need to change the template code)?</p>
</blockquote>
<p>Yes, see my PR: <a href="https://github.com/os-autoinst/openQA/pull/3494" class="external">https://github.com/os-autoinst/openQA/pull/3494</a></p>
openQA Project - action #76741: help popup next to "Submit comment" does not work anymorehttps://progress.opensuse.org/issues/76741?journal_id=3447102020-10-29T14:00:28Zlivdywanliv.dywan@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul> openQA Project - action #76741: help popup next to "Submit comment" does not work anymorehttps://progress.opensuse.org/issues/76741?journal_id=3447972020-10-29T15:52:19Zmkittlermarius.kittler@suse.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul> openQA Project - action #76741: help popup next to "Submit comment" does not work anymorehttps://progress.opensuse.org/issues/76741?journal_id=3449052020-10-29T19:15:32Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li></ul><p>happy to see this fixed fast but: We should ensure this actually works in production or have a proper test which ensures this, see <a href="https://progress.opensuse.org/projects/qa/wiki/Wiki#Definition-of-DONE" class="external">https://progress.opensuse.org/projects/qa/wiki/Wiki#Definition-of-DONE</a><br>
Seems like we have neither so far. Care to add a test?</p>
openQA Project - action #76741: help popup next to "Submit comment" does not work anymorehttps://progress.opensuse.org/issues/76741?journal_id=3452652020-10-30T15:58:01Zmkittlermarius.kittler@suse.com
<ul></ul><p>Wait, at some point you've said we don't necessarily have to wait with resolving tickets until the change has been deployed. I did of course a local, manual test and for a change like this it is fair to assume that there will be no difference in production.</p>
<blockquote>
<p>Care to add a test?</p>
</blockquote>
<p>PR: <a href="https://github.com/os-autoinst/openQA/pull/3498" class="external">https://github.com/os-autoinst/openQA/pull/3498</a></p>
openQA Project - action #76741: help popup next to "Submit comment" does not work anymorehttps://progress.opensuse.org/issues/76741?journal_id=3452892020-10-30T17:14:01Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>I hope what I am saying is also aligned with what we have written down as definition of DONE :)</p>
<p>Yes, "we don't necessarily have to wait" for deployment but the issue had been seen in production so in these cases I think it makes more sense to wait, especially if there aren't tests added. But as said PR is merged by now we can also resolved. For any weird reason this might still fail in production though. For example waiting for the daily deployment on i3 you could have realized it's actually not broken since 12 days :D don't worry, covered in another ticket, possibly broken by me.</p>
<p>I think it's good practice to not only try to address the problem at hand in a ticket but also ask ourselves how it could have come to the situation that something like this breaks and we did not know. It was actually a little bit embarrassing as I was showing some openQA features to someone and wanted to show him on my shared screen that all he needs is available in the help popup ... but it did not popup :D</p>