https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842020-10-19T07:44:33ZopenSUSE Project Management ToolopenQA Infrastructure - action #73501: Bind mounts of fixed assets is racyhttps://progress.opensuse.org/issues/73501?journal_id=3369792020-10-19T07:44:33Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>okurz</i></li><li><strong>Target version</strong> set to <i>Ready</i></li></ul> openQA Infrastructure - action #73501: Bind mounts of fixed assets is racyhttps://progress.opensuse.org/issues/73501?journal_id=3369822020-10-19T08:01:35Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul><p>coolo wrote:</p>
<blockquote>
<p>Whoever, whatever - but osd rebooted at sunday 3am</p>
</blockquote>
<p>yes, that is done automatically by "rebootmgr" whenever there are package upgrades that ask for a reboot, e.g. kernel upgrade. It also helps us to find these problems and not wait for the poor person that reboots the server only once every 3 years ;)</p>
<p>Created<br>
<a href="https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/382" class="external">https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/382</a><br>
with a fixed /etc/fstab</p>
<p>To my understanding we only need dependencies for the directories in which we want to bind mount to because any mount point specified below an existing one already depends on all parent directory levels.</p>
<p>Also testing on lord.arch</p>
<p>EDIT: Test on lord.arch successful with:</p>
<pre><code>UUID=5140113d-99e0-4244-beac-8787e56c0946 /var/lib/openqa btrfs subvol=@/var/lib/openqa 0 0
/abuild/pool /var/lib/openqa/pool none x-systemd.requires=/var/lib/openqa,x-systemd.automount,bind 0 0
</code></pre>
<p>I am wondering though if the additional dependencies are really necessary because currently on osd (without the change in /etc/fstab):</p>
<pre><code>$ systemctl list-dependencies var-lib-openqa-share-factory-hdd-fixed.mount
var-lib-openqa-share-factory-hdd-fixed.mount
● ├─-.mount
● ├─space\x2dslow.mount
● ├─system.slice
● ├─var-lib-openqa-share.mount
● └─var-lib-openqa.mount
</code></pre>
<p>so both the source and target parent mount points are there, what should be missing?</p>
openQA Infrastructure - action #73501: Bind mounts of fixed assets is racyhttps://progress.opensuse.org/issues/73501?journal_id=3370032020-10-19T08:16:51Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-3 priority-5 priority-high3 closed behind-schedule" href="/issues/64941">action #64941</a>: after every reboot openqaworker7 is missing var-lib-openqa-share.mount , check dependencies of service with openqaworker1</i> added</li></ul> openQA Infrastructure - action #73501: Bind mounts of fixed assets is racyhttps://progress.opensuse.org/issues/73501?journal_id=3370212020-10-19T08:42:46Zcoolocoolo@suse.com
<ul></ul><p>Is this after a reboot? I changed the fstab to have the mount point on /var/lib/openqa/share/factory instead of /assets and umounted and mounted manually to work around the issue</p>
openQA Infrastructure - action #73501: Bind mounts of fixed assets is racyhttps://progress.opensuse.org/issues/73501?journal_id=3378102020-10-20T21:29:22Zokurzokurz@suse.com
<ul></ul><p>The output of <code>systemctl list-dependencies var-lib-openqa-share-factory-hdd-fixed.mount</code> was before any reboot, I did not trigger any.</p>
openQA Infrastructure - action #73501: Bind mounts of fixed assets is racyhttps://progress.opensuse.org/issues/73501?journal_id=3426942020-10-25T20:47:45Zokurzokurz@suse.com
<ul><li><strong>Due date</strong> set to <i>2020-11-08</i></li></ul><p>I assume this should be ok but we should await some osd reboots, either manually induced or automatic.</p>
openQA Infrastructure - action #73501: Bind mounts of fixed assets is racyhttps://progress.opensuse.org/issues/73501?journal_id=3484422020-11-08T19:54:48Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Apparently was not enough, see <a href="https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/399" class="external">https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/399</a></p>
<p>merged and deployed manually as gitlab CI runners are currently not picked up default (EngInfra was informed). After <code>git pull --rebase</code> as root@osd in /srv/salt I called <code>salt --no-color -l error -C 'G@roles:webui' state.apply</code>, triggered reboot to check as currently only 5 jobs are running.</p>
<p>Verified working fine and dependencies look ok, e.g. when calling <code>systemctl cat var-lib-openqa-share-factory-hdd-fixed.automount</code> and others.</p>