Actions
action #66206
closed[functional][y] Use YAML::PP feature to include test_data files instead of custom key
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Refactor/Code Improvements
Target version:
SUSE QA - SLE 15 SP2
Start date:
2020-04-29
Due date:
2020-06-02
% Done:
0%
Estimated time:
8.00 h
Difficulty:
Description
We have used $include
key for including new files.
YAML::PP supports that out of the box, so we can use the library instead of own implementation.
We should also not limit file inclusion to test_data only and allow splitting schedules into multiple ones, so that keys can be merged, for instance.
Also note, that using constructor for parser will be necessary, as legacy interface is currently used.
See https://metacpan.org/pod/YAML::PP::Schema::Include
Acceptance criteria¶
- YAML::PP is used to include other yaml files
- $include keyword is not used anymore and schedules are adjusted accordingly
- In case of same setting being given in multiple files we should have deterministic behavior
- CI checks are adjusted accordingly
- Documentation is updated
- Unit tests are updated
Further info¶
Do not forget to enable merge key functionality by:
my $ypp = YAML::PP->new( schema => [qw(+ Merge)] );
my $ypp = YAML::PP->new( schema => ['JSON', $include] );
Updated by riafarov almost 4 years ago
- Description updated (diff)
- Due date changed from 2020-05-19 to 2020-06-02
Updated by riafarov almost 4 years ago
- Description updated (diff)
- Status changed from New to Workable
- Estimated time set to 8.00 h
Updated by riafarov almost 4 years ago
- Target version changed from Milestone 35+ to SLE 15 SP2
Updated by oorlov almost 4 years ago
- Status changed from Workable to In Progress
- Assignee set to oorlov
Updated by oorlov almost 4 years ago
- Status changed from In Progress to Feedback
Updated by riafarov almost 4 years ago
- Status changed from Feedback to Resolved
Looks that we are good.
Actions