action #66083
closed[opensuse][gnome3.36] test fails in gnome_music: Passwordless PolicyKit dialog not handled properly
0%
Description
There is no special code for handling the dialog on the live medium, which does not have a password set for root.
It types in the password anyway and hits return, but the Cancel button is focused.
Before https://github.com/os-autoinst/os-autoinst-distri-opensuse/commit/e1c9e01a4eb6e752a69cdc377b5e9542e87fb9ae, it just ignored the failure and interpreted the exit code of 7 as "success" (which is wrong).
Observation¶
openQA test in scenario opensuse-Tumbleweed-GNOME-Live-x86_64-gnome-live@64bit-4G fails in
gnome_music
Test suite description¶
Maintainer: okurz@suse.de, dimstar@opensuse.org
Test for openSUSE GNOME Next Live-Media
EXCLUDE_MODULES is a workaround for https://bugzilla.opensuse.org/show_bug.cgi?id=1138401#c10
Reproducible¶
Fails since (at least) Build 20200425
Expected result¶
Last good: 20200423 (or more recent)
Further details¶
Always latest result in this scenario: latest
Updated by zcjia almost 4 years ago
This failure is not caused by https://github.com/os-autoinst/os-autoinst-distri-opensuse/commit/e1c9e01a4eb6e752a69cdc377b5e9542e87fb9ae (aka https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10003), but caused by upgrade to GNOME-3.36, the PR#10003 just exposed this problem.
Updated by dimstar almost 4 years ago
zcjia wrote:
This failure is not caused by https://github.com/os-autoinst/os-autoinst-distri-opensuse/commit/e1c9e01a4eb6e752a69cdc377b5e9542e87fb9ae (aka https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10003), but caused by upgrade to GNOME-3.36, the PR#10003 just exposed this problem.
That's a bit an optimistic statement: https://openqa.opensuse.org/tests/1245896#step/gnome_music/16 is from the exactly same snapshot but happened to run before the merge identified by fvogt. And passes.
I attempted a restart from snapshot 0423 (GNOME 3.34, https://openqa.opensuse.org/tests/1246739) - I think the same 'issue' would have been exposed there as well with the latest openQA test changes (just confirming that the 'upgrade to GNOME 3.36 did not create something new - and if 3.34 is also affected, that means SLE is affected)
Updated by zcjia almost 4 years ago
- Subject changed from [opensuse] test fails in gnome_music: Passwordless PolicyKit dialog not handled properly to [opensuse][gnome3.36] test fails in gnome_music: Passwordless PolicyKit dialog not handled properly
dimstar wrote:
zcjia wrote:
This failure is not caused by https://github.com/os-autoinst/os-autoinst-distri-opensuse/commit/e1c9e01a4eb6e752a69cdc377b5e9542e87fb9ae (aka https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10003), but caused by upgrade to GNOME-3.36, the PR#10003 just exposed this problem.
That's a bit an optimistic statement: https://openqa.opensuse.org/tests/1245896#step/gnome_music/16 is from the exactly same snapshot but happened to run before the merge identified by fvogt. And passes.
I attempted a restart from snapshot 0423 (GNOME 3.34, https://openqa.opensuse.org/tests/1246739) - I think the same 'issue' would have been exposed there as well with the latest openQA test changes (just confirming that the 'upgrade to GNOME 3.36 did not create something new - and if 3.34 is also affected, that means SLE is affected)
Compare https://openqa.opensuse.org/tests/1245896#step/gnome_music/10 (gnome3.36, failure reason: Failed to obtain authentication) and https://openqa.opensuse.org/tests/1243498#step/gnome_music/10 (gnome3.34, failure reason: The packages are already all installed, meaning authentication successful).
So the failure reason should be, in gnome3.36, when you press "Enter", it selects "Cancel" instead of "Authenticate".
Updated by dimstar almost 4 years ago
zcjia wrote:
dimstar wrote:
zcjia wrote:
This failure is not caused by https://github.com/os-autoinst/os-autoinst-distri-opensuse/commit/e1c9e01a4eb6e752a69cdc377b5e9542e87fb9ae (aka https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10003), but caused by upgrade to GNOME-3.36, the PR#10003 just exposed this problem.
That's a bit an optimistic statement: https://openqa.opensuse.org/tests/1245896#step/gnome_music/16 is from the exactly same snapshot but happened to run before the merge identified by fvogt. And passes.
I attempted a restart from snapshot 0423 (GNOME 3.34, https://openqa.opensuse.org/tests/1246739) - I think the same 'issue' would have been exposed there as well with the latest openQA test changes (just confirming that the 'upgrade to GNOME 3.36 did not create something new - and if 3.34 is also affected, that means SLE is affected)
Compare https://openqa.opensuse.org/tests/1245896#step/gnome_music/10 (gnome3.36, failure reason: Failed to obtain authentication) and https://openqa.opensuse.org/tests/1243498#step/gnome_music/10 (gnome3.34, failure reason: The packages are already all installed, meaning authentication successful).
So the failure reason should be, in gnome3.36, when you press "Enter", it selects "Cancel" instead of "Authenticate".
That is debatable if a password-less dialog to give root access should default to 'grant' or 'deny'. I'm sure there are arguments for both sides (so basicaly posing the question if the fix should be in the test to pick authenticate or if the code should default to authenticate)
Updated by okurz almost 4 years ago
- Priority changed from Normal to High
Updated by dimstar almost 4 years ago
Updated by okurz almost 4 years ago
- Status changed from New to In Progress
- Assignee set to dimstar
then please assign the ticket to yourself. The PR looks good though I commented with improvement ideas on the PR.
Updated by dimstar almost 4 years ago
- Status changed from In Progress to Resolved