https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842019-08-22T05:03:47ZopenSUSE Project Management ToolopenQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2373292019-08-22T05:03:47Zmlin7442mlin@suse.com
<ul></ul><p>so I think opensuse_welcome module should not applicable if ROOTONLY=1</p>
<p>or this is a product bug ie. why not starts with root, need investigating.</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2373802019-08-22T10:18:30ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Subject</strong> changed from <i>test fails in opensuse_welcome - does not have welcome dialog for root logged in</i> to <i>[opensuse] test fails in opensuse_welcome - does not have welcome dialog for root logged in</i></li><li><strong>Assignee</strong> set to <i>mlin7442</i></li></ul><p>I would say that this is a product bug. Assigning to you since you are investigating the issue.</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2402062019-09-02T11:13:21ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Parent task</strong> set to <i>#56267</i></li></ul> openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2402242019-09-02T11:22:05ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li></ul><p>It seems this doesn't have activity. Please, feel free to unassign if you want U-Team to take over.</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2407672019-09-03T08:38:41Zfavogtfvogt@suse.com
<ul></ul><p>The log shows the reason:</p>
<p>Aug 21 17:53:13 install org.opensuse.opensuse_welcome.desktop[2284]: [2284:2284:0821/175313.472485:ERROR:zygote_host_impl_linux.cc(89)] Running as root without --no-sandbox is not supported. See <a href="https://crbug.com/638180" class="external">https://crbug.com/638180</a>.</p>
<p>The embedded chromium used by opensuse-welcome does not support running as root.</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2440762019-09-17T13:31:30ZStefanBruensstefan.bruens@rwth-aachen.de
<ul></ul><p>So, what should be done here?</p>
<p>As favogt pointed out, openSUSE Welcome will not run for the root user. I would even argue not automatically starting a web browser with "arbitrary" content should be checked for.</p>
<p>So (pseudocode):</p>
<pre><code>if (ROOTONLY) {
check_screen(opensuse-welcome) and die ("openSUSE Welcome should not run for the root user");
} else {
# do as before, i.e. unselect and close
}
</code></pre>
<p>Opinions?</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2440822019-09-17T13:39:25ZSLindoMansillaslindomansilla@suse.com
<ul></ul><p>StefanBruens wrote:</p>
<blockquote>
<p>So, what should be done here?</p>
<p>As favogt pointed out, openSUSE Welcome will not run for the root user. I would even argue not automatically starting a web browser with "arbitrary" content should be checked for.</p>
<p>So (pseudocode):</p>
<pre><code>if (ROOTONLY) {
check_screen(opensuse-welcome) and die ("openSUSE Welcome should not run for the root user");
} else {
# do as before, i.e. unselect and close
}
</code></pre>
<p>Opinions?</p>
</blockquote>
<p>So, as I expected, that needs to be taken in addition to <a href="https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8451#discussion_r325169288" class="external">https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8451#discussion_r325169288</a></p>
<p>So, a function with the handling logic has to be created. Then this function has to be called when needed. Maybe we even can get rid of the opensuse_welcome module, or this module should only call that function.</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2441722019-09-17T17:13:50ZStefanBruensstefan.bruens@rwth-aachen.de
<ul></ul><p>SLindoMansilla wrote:</p>
<blockquote>
<p>So, as I expected, that needs to be taken in addition to <a href="https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8451#discussion_r325169288" class="external">https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8451#discussion_r325169288</a></p>
<p>So, a function with the handling logic has to be created. Then this function has to be called when needed. Maybe we even can get rid of the opensuse_welcome module, or this module should only call that function.</p>
</blockquote>
<p>Or just extend opensuse_welcome, no duplication needed.</p>
<p>The big advantage of keeping opensuse_welcome a module instead of a function call is one can actually check whats going on, without 5 levels of functions and nested state to be handled: <a href="https://openqa.opensuse.org/tests/1033059/modules/opensuse_welcome/steps/1/src" class="external">https://openqa.opensuse.org/tests/1033059/modules/opensuse_welcome/steps/1/src</a></p>
<p>The wait_boot function in reboot_icewm <a href="https://openqa.opensuse.org/tests/1033059" class="external">https://openqa.opensuse.org/tests/1033059</a> does what the name says - it waits for the (re)boot to complete.</p>
<p><strong>When the boot has completed</strong> there is either a plain desktop or the dialog, which should be handled accordingly.</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2443612019-09-18T09:37:54ZSLindoMansillaslindomansilla@suse.com
<ul></ul><p>StefanBruens wrote:</p>
<blockquote>
<p>Or just extend opensuse_welcome, no duplication needed.</p>
<p>The big advantage of keeping opensuse_welcome a module instead of a function call is one can actually check whats going on, without 5 levels of functions and nested state to be handled: <a href="https://openqa.opensuse.org/tests/1033059/modules/opensuse_welcome/steps/1/src" class="external">https://openqa.opensuse.org/tests/1033059/modules/opensuse_welcome/steps/1/src</a></p>
</blockquote>
<p>This ticket was open to this kind of implementation.<br>
Your PR made me think it is not possible. So, let's extend the opensuse_welcome module so that <a href="https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8451#discussion_r325169288" class="external">your PR</a> is not needed. Otherwise you are not argumenting in favor of your PR.</p>
<p>If your PR is still necessary and the opensuse_welcome module cannot be extended to avoid the changes on your PR, then I still beg for a function that is used in the places your PR addresses and in the opensuse_welcome module.</p>
<blockquote>
<p>The wait_boot function in reboot_icewm <a href="https://openqa.opensuse.org/tests/1033059" class="external">https://openqa.opensuse.org/tests/1033059</a> does what the name says - it waits for the (re)boot to complete.</p>
<p><strong>When the boot has completed</strong> there is either a plain desktop or the dialog, which should be handled accordingly.</p>
</blockquote>
<p>You are basically saying that I am right. A proper function that does what is expected is better when we have to call this logic in different modules and scenarios.<br>
The wait_boot function was created after the pain of having several modules in several places for several products implementing several ways of rebooting, waiting for boot. So, even if that function exists, it is a pain to change the code without breaking another module in another scenario from another SUSE product. So, even if the function does what is expected, it is not used in all places.<br>
Example of horror story: <a href="https://progress.opensuse.org/issues/38423" class="external">https://progress.opensuse.org/issues/38423</a></p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2477032019-10-03T05:24:35Zokurzokurz@suse.com
<ul></ul><p>This is an autogenerated message for openQA integration by the openqa_review script:</p>
<p>This bug is still referenced in a failing openQA test: rootonly<br>
<a href="https://openqa.opensuse.org/tests/1045686" class="external">https://openqa.opensuse.org/tests/1045686</a></p>
<p>To prevent further reminder comments one of the following options should be followed:</p>
<ol>
<li>The test scenario is fixed by applying the bug fix to the tested product or the test is adjusted</li>
<li>The openQA job group is moved to "Released"</li>
<li>The label in the openQA scenario is removed</li>
</ol>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2511052019-10-18T05:29:04Zokurzokurz@suse.com
<ul></ul><p>This is an autogenerated message for openQA integration by the openqa_review script:</p>
<p>This bug is still referenced in a failing openQA test: rootonly<br>
<a href="https://openqa.opensuse.org/tests/1058820" class="external">https://openqa.opensuse.org/tests/1058820</a></p>
<p>To prevent further reminder comments one of the following options should be followed:</p>
<ol>
<li>The test scenario is fixed by applying the bug fix to the tested product or the test is adjusted</li>
<li>The openQA job group is moved to "Released"</li>
<li>The label in the openQA scenario is removed</li>
</ol>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2542712019-11-01T06:28:48Zokurzokurz@suse.com
<ul></ul><p>This is an autogenerated message for openQA integration by the openqa_review script:</p>
<p>This bug is still referenced in a failing openQA test: rootonly<br>
<a href="https://openqa.opensuse.org/tests/1071859" class="external">https://openqa.opensuse.org/tests/1071859</a></p>
<p>To prevent further reminder comments one of the following options should be followed:</p>
<ol>
<li>The test scenario is fixed by applying the bug fix to the tested product or the test is adjusted</li>
<li>The openQA job group is moved to "Released"</li>
<li>The label in the openQA scenario is removed</li>
</ol>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2570312019-11-13T12:15:11ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/257031/diff?detail_id=253362">diff</a>)</li><li><strong>Assignee</strong> deleted (<del><i>mlin7442</i></del>)</li></ul><p>Two months of inactivity after the reminder. U-Team will take over ;)</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2570402019-11-13T12:15:44ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Follows</strong> <i><a class="issue tracker-4 status-3 priority-5 priority-high3 closed child" href="/issues/55661">action #55661</a>: [opensuse][u] test fails in several modules after booting and login - "openSUSE Welcome" not handled (WAS: test fails in first_boot)</i> added</li></ul> openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2570432019-11-13T12:17:18ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Blocked</i></li></ul><p>Tracking.<br>
By now, I have added <strong>EXCLUDE_MODULES=opensuse_welcome</strong> to the test suite <strong>rootonly</strong> on <a href="https://openqa.opensuse.org/admin/test_suites" class="external">https://openqa.opensuse.org/admin/test_suites</a></p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2570462019-11-13T12:17:55ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Assignee</strong> set to <i>SLindoMansilla</i></li></ul> openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2730322020-01-21T10:00:48ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Status</strong> changed from <i>Blocked</i> to <i>New</i></li></ul> openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2788572020-02-19T09:27:41ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Assignee</strong> deleted (<del><i>SLindoMansilla</i></del>)</li></ul> openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2987292020-05-07T14:10:53ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Subject</strong> changed from <i>[opensuse] test fails in opensuse_welcome - does not have welcome dialog for root logged in</i> to <i>[opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged in</i></li></ul><ol>
<li>Create YAML schedule</li>
<li>Remove the <code>EXCLUDE_MODULES</code> setting</li>
</ol>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2990652020-05-11T07:53:14ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/299065/diff?detail_id=295981">diff</a>)</li></ul> openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2990682020-05-11T07:54:41ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/299068/diff?detail_id=295984">diff</a>)</li></ul> openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2991252020-05-11T09:13:53ZSLindoMansillaslindomansilla@suse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Workable</i></li><li><strong>Target version</strong> set to <i>Milestone 30</i></li><li><strong>Estimated time</strong> set to <i>42.00 h</i></li></ul> openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2999772020-05-13T14:30:25Zzluo
<ul><li><strong>Status</strong> changed from <i>Workable</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>zluo</i></li></ul><p>take over</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=2999862020-05-13T14:40:48Zzluo
<ul></ul><p>this can be done like my PR: <a href="https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10028" class="external">https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10028</a></p>
<p>add yaml schedule for rootonly scenairo and remove EXCLUDE_MODULES item.</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=3010812020-05-18T10:15:14Zzluo
<ul></ul><p><a href="https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10294" class="external">https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10294</a> created.</p>
<p>will remove EXCLUDE_MODULES=opensuse_welcome after merge.</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=3014052020-05-19T10:32:37Zzluo
<ul></ul><p>PR merged now, rootonly test suite updated now at <a href="https://openqa.opensuse.org/admin/test_suites" class="external">https://openqa.opensuse.org/admin/test_suites</a></p>
<p>check this later on O3 for this change.</p>
openQA Tests - action #55805: [opensuse][functional][u] test fails in opensuse_welcome - does not have welcome dialog for root logged inhttps://progress.opensuse.org/issues/55805?journal_id=3020082020-05-22T07:41:05Zzluo
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p><a href="https://openqa.opensuse.org/tests/1273764:" class="external">https://openqa.opensuse.org/tests/1273764:</a> resolved now.</p>