Project

General

Profile

Actions

action #53801

closed

[functional][y] Move 'start bootloader from read-only snapshot' selection out of 'grub_test' module

Added by oorlov over 4 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
Low
Assignee:
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 29
Start date:
2019-07-03
Due date:
2019-11-05
% Done:

0%

Estimated time:
3.00 h
Difficulty:

Description

Motivation

Currently, grub_test.pm module contains sub boot_into_snapshot which selects 'start bootloader from snapshot' in bootloader menu (please, see the openQA step for more details).

grub_test.pm is not the right place to select bootloader menu items. The selection should be moved out of the test module.

Acceptance Criteria

  1. Move sub boot_into_snapshot to boot_into_snapshot.pm test module (or re-think on where the right place for selection of the bootloader menu);
  2. Verify that grub_test.pm is still working in all the test suites where it is scheduled;
  3. Verify that boot_into_snapshot.pm (or the module, that was chosen in AC1) is still working in all the test suites where it is scheduled.
Actions #1

Updated by riafarov over 4 years ago

  • Due date set to 2019-08-13
  • Target version set to Milestone 26
Actions #2

Updated by riafarov over 4 years ago

  • Estimated time set to 3.00 h
Actions #3

Updated by riafarov over 4 years ago

  • Status changed from New to Workable
Actions #4

Updated by ybonatakis over 4 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions #5

Updated by ybonatakis over 4 years ago

i have to admit that i cant see why the grub_test is not the right place to handle this. What is misleading for me is the name of the module which indicated that is gonna be a test but from the description seems that grub_test is there to handle the booting. So IMO it would be just better to rename this module.

Otherwise i can see two outcomes.
1 - we create another module to handle the boot from the grub to the snapshot option. for me it is a problem because the grub_test is there for that very reason (unless i dont understand something)
2 - we try to move the functionality into the boot_from_snapshot. But then i think we end up with repetitive code for the grub. In this case we have also to reschedule all the jobs that contains the boot_from_snapshot removing the grub_test.

Actions #6

Updated by ybonatakis over 4 years ago

  • Status changed from In Progress to Feedback
Actions #7

Updated by JERiveraMoya over 4 years ago

As discussed, my recommendation would be to unscheduled grub_test.pm from the test suite and move boot_into_snapshot if get_var("BOOT_TO_SNAPSHOT") to boot_into_snapshot.pm to have the graphical part of grub and the rollback all together, due to modify grub_test.pm could cost many verification if the functionality is extracted as this module is widely shared. Let's leave this ticket in feedback for someone else to through some idea.

Actions #8

Updated by ybonatakis over 4 years ago

  • Assignee deleted (ybonatakis)
Actions #9

Updated by riafarov over 4 years ago

  • Target version changed from Milestone 26 to Milestone 27
Actions #10

Updated by riafarov over 4 years ago

  • Due date changed from 2019-08-13 to 2019-09-10
  • Status changed from Feedback to Workable
  • Priority changed from Normal to Low
Actions #11

Updated by riafarov over 4 years ago

  • Due date changed from 2019-09-10 to 2019-09-24
Actions #12

Updated by riafarov over 4 years ago

  • Due date changed from 2019-09-24 to 2019-10-08
Actions #13

Updated by mgriessmeier over 4 years ago

  • Target version changed from Milestone 27 to Milestone 28
Actions #14

Updated by JERiveraMoya over 4 years ago

  • Due date changed from 2019-10-08 to 2019-10-22
Actions #15

Updated by riafarov over 4 years ago

  • Due date changed from 2019-10-22 to 2019-11-05
Actions #16

Updated by ybonatakis over 4 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions #18

Updated by ybonatakis over 4 years ago

  • Status changed from In Progress to Feedback
Actions #19

Updated by riafarov over 4 years ago

  • Target version changed from Milestone 28 to Milestone 29
Actions #20

Updated by riafarov over 4 years ago

After Yanis did some work regarding this issue: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8673 I feel like we cannot do it right, especially with estimate of 3.0 story points.

So I would propose to drop this one and keep for future when we will have enough time to make test modules atomic per actions they do.

Actions #21

Updated by riafarov over 4 years ago

  • Status changed from Feedback to Rejected

As per comment in the PR, we agreed that we cannot reach what we wanted originally and ticket was misleading.

Actions

Also available in: Atom PDF