Project

General

Profile

Actions

action #51680

closed

[sle][functional][y] Detect missing `textdomain` declarations with explicit exception

Added by riafarov almost 5 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Enhancement to existing tests
Target version:
SUSE QA - Milestone 30
Start date:
2019-05-20
Due date:
2020-01-28
% Done:

0%

Estimated time:
3.00 h
Difficulty:

Description

Motivation

As per request (see https://github.com/yast/yast-ruby-bindings/pull/230).
Now we have setting to detect untranslated text in the dialogs using Y2STRICTTEXTDOMAIN=1 boot option.
We already have text detection which is used in the detect_yast2_failures scenario.
Would be helpful to include it at least in the installer_extended scenario.

NOTE: this feature is relevant for post SLE 15 SP1 only (including TW and Leap 15.2).
Y2STRICTTEXTDOMAIN is used as same as Y2DEBUG

Acceptance criteria

  1. Y2STRICTTEXTDOMAIN=1 is set at least in one scenario for SLE 15 SP1 or later
Actions #1

Updated by riafarov almost 5 years ago

  • Due date set to 2019-07-09
Actions #2

Updated by riafarov almost 5 years ago

  • Due date changed from 2019-07-09 to 2020-01-28
  • Target version changed from Milestone 26 to Milestone 30+
Actions #3

Updated by mgriessmeier about 4 years ago

  • Target version changed from Milestone 30+ to Milestone 30

bulk moved to M30 for revisiting

Actions #4

Updated by riafarov about 4 years ago

  • Description updated (diff)
  • Status changed from New to Workable
  • Estimated time set to 3.00 h
Actions #5

Updated by ybonatakis about 4 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions #6

Updated by ybonatakis about 4 years ago

  • Status changed from In Progress to Feedback

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/9406

The VR passed but the scenario to catch this error dialog is very small in our test suites. Even if the PR[1] which address this issue is still open.
Although one way that it might work is to install_extended_textmode to delete https://github.com/yast/yast-installation/blob/fadc47518b26beb5de2f91d41f0f101b6a07ef02/src/lib/installation/dialogs/complex_welcome.rb#L47 and the test should fail in the setp/welcome/3 (based on mvidner)

I filled another ticket[1] because i noticed that some yast modules are not using the yast2_console_exec which is used to pass the desired environment variable when yast is called.

[0] https://github.com/yast/yast-storage-ng/pull/925/files
[1] https://progress.opensuse.org/issues/62522

Actions #7

Updated by ybonatakis about 4 years ago

  • Status changed from Feedback to Resolved

I have added the EXTRABOOTPARAMS=Y2STRICTTEXTDOMAIN=1 to the installer_extended in both OSD and O3. installer_extended was the only one with EULA_LANGUAGES variables. I think we can resolve this ticket

Actions

Also available in: Atom PDF