https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842018-12-14T11:36:26ZopenSUSE Project Management ToolopenQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1740562018-12-14T11:36:26Zokurzokurz@suse.com
<ul><li><strong>Copied from</strong> <i><a class="issue tracker-4 status-3 priority-4 priority-default closed" href="/issues/44249">action #44249</a>: developer mode: "Stop timeout" - like in the old interactive mode :)</i> added</li></ul> openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1740682018-12-14T12:18:08Zmkittlermarius.kittler@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-3 priority-3 priority-lowest closed" href="/issues/39227">action #39227</a>: Handle the job being finished more nicely in developer mode</i> added</li></ul> openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1740802018-12-14T12:20:03Zmkittlermarius.kittler@suse.com
<ul><li><strong>Copied from</strong> deleted (<i><a class="issue tracker-4 status-3 priority-4 priority-default closed" href="/issues/44249">action #44249</a>: developer mode: "Stop timeout" - like in the old interactive mode :)</i>)</li></ul> openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1741942018-12-14T14:11:35Zmkittlermarius.kittler@suse.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/174194/diff?detail_id=173633">diff</a>)</li><li><strong>Assignee</strong> set to <i>mkittler</i></li><li><strong>Target version</strong> set to <i>Current Sprint</i></li></ul> openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1763722019-01-03T16:50:07Zmkittlermarius.kittler@suse.com
<ul></ul><p>Even with my <a href="https://progress.opensuse.org/issues/39227#note-1" class="external">previous idea</a> this turns out to be hard to be implemented. So far I'm unable to prevent the command server from being interrupted until it informs the web socket clients.</p>
<p>Maybe I can also just delay showing the error message in the front-end. That would be a not nice solution but not sure whether messing with os-autoinst's IPC code is worth it.</p>
openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1774042019-01-08T17:07:25Zmkittlermarius.kittler@suse.com
<ul></ul><p>The code in isotovideo to terminate (and eventually kill) its subprocesses is only one way those subprocesses are terminated/killed. The worker-side also attempts to terminate/kill those subprocesses. Apparently we or better mudler re-implemented his own container here. That is why I had no success with extending the livetime of the command server to send some last command.</p>
<p>When working on that I come to the conclusion that we really need more documentation about the whole openQA architecture (not only specific packages and methods). It occupied me quite a while to reverse-engineer/understand what's happening here.</p>
<p>I find it also weird to have isotovideo itself taking care about its subprocess and terminating them also on the worker-side. Additionally, the use of <code>Mojo::IOLoop::ReadWriteProcess::Session</code> and <code>Mojo::IOLoop::ReadWriteProcess::Container</code> is kind of subtitle considering its impact/implications.</p>
<hr>
<p>To solve this issue I could adjust the worker so it doesn't try to terminate/kill isotovideo. Instead it sends a command to the command server which will then informs web socket clients and stops. The worker could still attempt to terminate/kill isotovideo if stopping via the command server didn't work. That way I would not have to touch any of the session/container code and just let that be the fallback.</p>
openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1777252019-01-09T12:25:58Zmkittlermarius.kittler@suse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li></ul><p>Before implementing the 2nd approach (and possibly scraping it again) I'd like to have some feedback.</p>
openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1787182019-01-11T13:02:44Zmkittlermarius.kittler@suse.com
<ul></ul><p>WIP branches for 2nd approach:</p>
<ul>
<li><a href="https://github.com/os-autoinst/os-autoinst/compare/master...Martchus:devel_mode_prevent_error2" class="external">https://github.com/os-autoinst/os-autoinst/compare/master...Martchus:devel_mode_prevent_error2</a></li>
<li><a href="https://github.com/os-autoinst/openQA/compare/master...Martchus:devel_mode_prevent_error2" class="external">https://github.com/os-autoinst/openQA/compare/master...Martchus:devel_mode_prevent_error2</a></li>
</ul>
<p>Right now I'm stuck because the HTTP request from the worker to os-autoinst command server does not work yet. Maybe <a class="user active user-mention" href="https://progress.opensuse.org/users/23018">@kraih</a> can help when he's no longer sick.</p>
openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1832212019-01-29T16:59:07Zmkittlermarius.kittler@suse.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>In Progress</i></li></ul><p>It should work now:</p>
<ul>
<li>PR for isotovideo and command server part: <a href="https://github.com/os-autoinst/os-autoinst/pull/1093" class="external">https://github.com/os-autoinst/os-autoinst/pull/1093</a></li>
<li>PR for worker and UI part: <a href="https://github.com/os-autoinst/openQA/pull/1981" class="external">https://github.com/os-autoinst/openQA/pull/1981</a></li>
</ul>
openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=1857802019-02-06T13:18:18Zmkittlermarius.kittler@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>PRs are merged so the error should be gone as soon as everything is deployed.</p>
openQA Project - action #45191: developer mode: error message just when clicking "Cancel job"https://progress.opensuse.org/issues/45191?journal_id=2478292019-10-04T13:06:48Zokurzokurz@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-3 priority-4 priority-default closed" href="/issues/57707">action #57707</a>: isotovideo fails to terminate cleanly, message "isotovideo: unable to inform websocket clients about stopping command server: Request timeout", regression from 4cd4af2b</i> added</li></ul>