Project

General

Profile

Actions

action #44450

closed

[functional][y] Adjust test modules to yast lan changes

Added by riafarov over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Bugs in existing tests
Target version:
SUSE QA - Milestone 22
Start date:
2018-11-28
Due date:
2019-02-12
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

See more details in https://trello.com/c/so0amSNp/342-sle-15-sp1-yast2-network-clarify-hostname-setup

This will require fixes for following test modules:
console/yast2_lan.pm
console/yast2_lan_hostname.pm
tests/x11/yast2_lan_restart_devices.pm

Acceptance criteria

  1. Tests are adjusted to the new UI
  2. Tests still work for distributions which have old UI
  3. Changes should be based on PR provided https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6276

Suggestions

Potentially we should move more common parts to lib/y2lan_restart_common.pm if any detected


Related issues 4 (0 open4 closed)

Related to openQA Tests - action #45023: [functional][y] Reneedle expert partitioner due to icon changesResolvedokurz2018-12-122019-01-01

Actions
Related to openQA Tests - action #44786: [sle][functional][y][medium] Create test suite to test that YaST2 lan rewrite hostname change properly (bsc#1052042)ResolvedJRivrain2018-12-052018-12-18

Actions
Related to openQA Tests - action #38195: [sle][functional][y] test fails in yast2_lan - yast2_lan is not starting upRejectedokurz2018-07-04

Actions
Related to openQA Tests - action #47318: [functional][y][fast] leap 42.3 openssh tests broken since february 7thResolvedriafarov2019-02-092019-02-26

Actions
Actions #1

Updated by riafarov over 5 years ago

  • Status changed from Workable to Blocked
  • Assignee set to riafarov
Actions #2

Updated by okurz over 5 years ago

https://build.opensuse.org/request/show/652281 is the corresponding openSUSE:Factory SR, currently in review. I have seen no related staging tests, I guess the tests would not fail on these, let's see.

Actions #3

Updated by okurz over 5 years ago

  • Target version set to Milestone 21
Actions #4

Updated by okurz over 5 years ago

  • Category set to Bugs in existing tests
Actions #5

Updated by okurz over 5 years ago

#testing
[29/11/2018 14:24:55] <fcrozat> https://openqa.suse.de/tests/2287754#step/yast2_lan/13
[29/11/2018 14:25:15] <fcrozat> it looks like yast2_lan needs some love for latest yast2-network package
[29/11/2018 14:50:41] <okurz> fcrozat: I assume this is https://build.suse.de/request/show/178723 ?
[29/11/2018 14:51:04] <fcrozat> okurz (IRC): yes, this is part of some bug fixes / cleanup
[29/11/2018 14:51:28] <okurz> https://build.opensuse.org/request/show/652549 seems to be the corresponding Factory submission …
[29/11/2018 14:53:10] <okurz> couldn't find any related staging openQA tests for Factory staging, checking if we have a ticket for that …
[29/11/2018 14:54:57] <okurz> fcrozat: https://progress.opensuse.org/issues/44450 is the according ticket in our backlog. We are waiting for a failing Factory staging test before we would try to adapt the tests
Actions #6

Updated by riafarov over 5 years ago

  • Status changed from Blocked to New
Actions #7

Updated by okurz over 5 years ago

coolo was saying that https://openqa.suse.de/tests/overview?groupid=125&version=15-SP1&distri=sle&build=Y.133.1 is now in a state where it's purely QA work IMO.
I responded: coolo: thanks for your update. The plan was that QSF-y looks into the according changes in Factory staging first, e.g. https://openqa.opensuse.org/tests/813583#step/yast2_lan/14 as the comparable step.

Actions #8

Updated by okurz over 5 years ago

  • Priority changed from Normal to High

was mentioned by behlert and jsrain as they were looking into what is missing for Beta1.

Actions #9

Updated by okurz over 5 years ago

  • Status changed from New to Blocked

Informed behlert and jsrain in #dist that it was our plan to adjust the corresponding openSUSE Factory staging tests first and then have SLE covered. Also, I mentioned that we already knew about the issue but https://trello.com/c/so0amSNp/342-sle-15-sp1-yast2-network-clarify-hostname-setup still has open points, e.g. "UI changes blessed by Ken". We in QSF-y did not really want to update test cases again (because we already did multiple times in before in vain) only to see the UI change again.
jsrain informed: "I don't know why those are still open, Michal wanted to do even further changes which many (Lukas, me Thorsten) opposed. Anyway, the changes are now merged :-/"

Still, I would propose to try to not waste our efforts when potential UI changes might still come.

@riafarov agreed to block by the trello card? I also watch it now.

Actions #10

Updated by riafarov over 5 years ago

@okurz: sure, makes sense. Test doesn't have many steps and we also got new set of icons in the partitioner: https://progress.opensuse.org/issues/45023
And I also want to get it clarified that we don't reneedle multiple times which was already the case for the YaST staging for TW with the sidebar.

Actions #11

Updated by okurz over 5 years ago

SLE15SP1 PM behlert definitely wants to have the YaST changes in for SLE15SP1 Beta2 so we should really put more focus on this issue, not skipping over steps but support the YaST development team to have the first steps done faster.

@riafarov can you help to coordinate with the YaST team to help here?

Actions #12

Updated by okurz over 5 years ago

  • Related to action #45023: [functional][y] Reneedle expert partitioner due to icon changes added
Actions #13

Updated by okurz over 5 years ago

Also I will try to adress mfilka in #yast about the open points in the trello card.

Actions #14

Updated by okurz over 5 years ago

[13/12/2018 10:40:03] <okurz> I understood that https://trello.com/c/so0amSNp/342-sle-15-sp1-yast2-network-clarify-hostname-setup should be in SLE15SP1 Beta2 but I see open points in the checklist of this card so regarding adjustements of openQA tests we wanted to wait until this is confirmed so that we do not need to recreate needles multiple times and such. Anyone can clarify when we can expect this?
[13/12/2018 10:46:48] <jsrain> mchf: check comment from okurz ^^^
[13/12/2018 11:10:07] <mchf> jsrain, okurz: there are open points in trello bcs I asked ken for blessing ui change. I haven't got response so far. I'll ping him.
[13/12/2018 11:12:40] <okurz> mchf: thx. Depending on when we would receive an answer I hope we can ensure that according submissions to Factory and SLE15 along with the necessary openQA test adaptions happen soon enough so that we have a stable state for SLE15 Beta2
Actions #15

Updated by okurz over 5 years ago

[13/12/2018 23:00:57] <DimStar> okurz: RAID0 in Staging:M is green \o/ https://openqa.opensuse.org/tests/815044

But now there seems to be a problem with Networking, DimStar is investigating

Actions #16

Updated by riafarov over 5 years ago

  • Related to action #44786: [sle][functional][y][medium] Create test suite to test that YaST2 lan rewrite hostname change properly (bsc#1052042) added
Actions #17

Updated by riafarov over 5 years ago

  • Description updated (diff)
Actions #18

Updated by riafarov over 5 years ago

  • Due date changed from 2018-12-18 to 2019-01-08
  • Target version changed from Milestone 21 to Milestone 22
Actions #19

Updated by SLindoMansilla over 5 years ago

  • Related to action #38195: [sle][functional][y] test fails in yast2_lan - yast2_lan is not starting up added
Actions #20

Updated by SLindoMansilla over 5 years ago

Not sure if duplicate: #38195

It was reported against 12-SP4. But, it never failed again since then (3 months ago)

Actions #21

Updated by okurz over 5 years ago

  • Due date changed from 2019-01-08 to 2019-01-15

Adjust to sprint end date of current sprint

Actions #22

Updated by riafarov over 5 years ago

Still no feedback from UX side

Actions #23

Updated by riafarov over 5 years ago

  • Due date changed from 2019-01-15 to 2019-01-29
Actions #24

Updated by riafarov about 5 years ago

  • Status changed from Blocked to Workable

Changes are accepted by Ken.

Actions #25

Updated by riafarov about 5 years ago

  • Status changed from Workable to In Progress
Actions #26

Updated by riafarov about 5 years ago

  • Status changed from In Progress to Feedback
Actions #28

Updated by oorlov about 5 years ago

  • Due date changed from 2019-01-29 to 2019-02-12

PR not yet merged

Actions #31

Updated by okurz about 5 years ago

labeled the according xen scenario https://openqa.suse.de/tests/2430564#step/yast2_lan/108 as well

Actions #32

Updated by okurz about 5 years ago

btw, PR is merged. Just stating that readers are not confused why #44450#note-28 mentions it's not yet merged and the next comment #44450#note-29 states failing jobs.

Actions #33

Updated by okurz about 5 years ago

Sorry, have reverted the PR with https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6699 to fix openSUSE and staging and 15SP1 tests and such as some more tests have failed there.

EDIT: and … probably most importantly, openSUSE update tests.

Please see my comment in https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6648#issuecomment-459951218

Actions #36

Updated by riafarov about 5 years ago

  • Status changed from Feedback to Resolved
Actions #37

Updated by okurz about 5 years ago

  • Related to action #47318: [functional][y][fast] leap 42.3 openssh tests broken since february 7th added
Actions

Also available in: Atom PDF