Project

General

Profile

Actions

action #39869

closed

[sle][functional][u] do not use version in repo variable names (was: test fails in kdump_and_crash - missing SP1 repo variable in get_repo_url_for_kdump_sle subroutine)

Added by mloviska over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Bugs in existing tests
Target version:
SUSE QA - Milestone 19
Start date:
2018-08-16
Due date:
2018-10-09
% Done:

0%

Estimated time:
Difficulty:
easy

Description

Observation

openQA test in scenario sle-15-SP1-Installer-DVD-ppc64le-toolchain_zypper@ppc64le fails in
kdump_and_crash

We are missing sles-server debug repo because of incorrect openQA variable (should be REPO_SLE15_SP1_MODULE_BASESYSTEM_DEBUG).

sub get_repo_url_for_kdump_sle {
    return join('/', $utils::OPENQA_FTP_URL, get_var('REPO_SLE15_MODULE_BASESYSTEM_DEBUG'))
      if get_var('REPO_SLE15_MODULE_BASESYSTEM_DEBUG')
      and is_sle('15+');
    return join('/', $utils::OPENQA_FTP_URL, get_var('REPO_SLES_DEBUG')) if get_var('REPO_SLES_DEBUG');
}

In the main.pm we have code to inject version

my $repo_variable_name
              = is_module($short_name) ?
              "REPO_SLE${version}_MODULE_${repo_name}"
              : "REPO_SLE${version}_PRODUCT_${repo_name}";

In general it doesn't make sense to have version in the variable names. For that we should introduce changes to rsync.pl and then adjust tests code all usages of REPO_SLE_xxx

This will simplify test code and will work in future, as we already had to introduce fix for SP1 in main.pm to replace - with _

Acceptance criteria

  1. REPO_ variables do not include version in the name ## Reproducible

Fails since (at least) Build 19.7

Expected result

Last good: SLE15GM

Further details

Always latest result in this scenario: latest


Related issues 2 (0 open2 closed)

Related to openQA Tests - action #41894: [sle][functional][u][fast] test fails in yast2_clone_system - Could not retrieve required variable REPO_SLE_SDKResolvedoorlov2018-10-022018-10-09

Actions
Related to openQA Tests - action #41951: [sle][functional][u] test fails in zypper_info: REPO_SLES_SOURCE variable missingResolvedoorlov2018-10-032018-10-23

Actions
Actions #1

Updated by okurz over 5 years ago

  • Due date set to 2018-09-25
  • Target version set to Milestone 19
Actions #2

Updated by zluo over 5 years ago

  • Estimated time set to 2.00 h
  • Difficulty set to easy
Actions #3

Updated by mgriessmeier over 5 years ago

  • Status changed from New to Workable
Actions #4

Updated by okurz over 5 years ago

  • Due date deleted (2018-09-25)
  • Status changed from Workable to New
  • Target version changed from Milestone 19 to Milestone 21

hm, I am not so sure if this is really workable. I do not think it is a good idea to introduce a dependency to service pack versions which we would need to update for every service pack. We need to find a more generic solution.

Actions #5

Updated by riafarov over 5 years ago

  • Subject changed from [sle][functional][u] test fails in kdump_and_crash - missing SP1 repo variable in get_repo_url_for_kdump_sle subroutine to [sle][functional][u] do not use version in repo variable names (was: test fails in kdump_and_crash - missing SP1 repo variable in get_repo_url_for_kdump_sle subroutine)
  • Description updated (diff)
  • Estimated time deleted (2.00 h)
Actions #6

Updated by okurz over 5 years ago

  • Due date set to 2018-09-25
  • Status changed from New to Workable
  • Target version changed from Milestone 21 to Milestone 19
Actions #7

Updated by oorlov over 5 years ago

  • Assignee set to oorlov
Actions #8

Updated by oorlov over 5 years ago

  • Status changed from Workable to In Progress
Actions #10

Updated by oorlov over 5 years ago

  • Status changed from In Progress to Feedback
Actions #11

Updated by oorlov over 5 years ago

PRs are merged. Waiting for builds to be running on production.

Actions #12

Updated by oorlov over 5 years ago

  • Status changed from Feedback to In Progress

Moved back to In Progress, as the last merge caused issues with repo names.

Actions #13

Updated by SLindoMansilla over 5 years ago

  • Due date changed from 2018-09-25 to 2018-10-09

Moving to sprint 27. Not able to finish during sprint 26.

Actions #14

Updated by oorlov over 5 years ago

  • Status changed from In Progress to Feedback
Actions #15

Updated by okurz over 5 years ago

Both merged and effective. Could it be that #41894 is a fallout of this ticket?

Actions #16

Updated by okurz over 5 years ago

  • Related to action #41894: [sle][functional][u][fast] test fails in yast2_clone_system - Could not retrieve required variable REPO_SLE_SDK added
Actions #17

Updated by michalnowak over 5 years ago

  • Related to action #41951: [sle][functional][u] test fails in zypper_info: REPO_SLES_SOURCE variable missing added
Actions #18

Updated by oorlov over 5 years ago

  • Status changed from Feedback to Resolved

All necessary changes are done in https://gitlab.suse.de/openqa/scripts/merge_requests/255.

Example of the successful execution: https://openqa.suse.de/tests/2130511

Actions #19

Updated by okurz over 5 years ago

This is an autogenerated message for openQA integration by the openqa_review script:

This bug is still referenced in a failing openQA test: toolchain_zypper
https://openqa.suse.de/tests/2196997

Actions

Also available in: Atom PDF