Project

General

Profile

Actions

action #38453

closed

SP1 stagings don't get addon repos

Added by coolo almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Bugs in existing tests
Target version:
-
Start date:
2018-07-16
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

https://openqa.suse.de/tests/1832993 - how confident are we that sle_version_at_least('15') returns true for 15-SP1?


Related issues 1 (0 open1 closed)

Related to openQA Tests - action #38732: [sle][functional][y] test fails in addon_products_sle - Add hint to test if ADDONURL isn't setResolvedmloviska2018-07-232018-09-11

Actions
Actions #1

Updated by okurz almost 6 years ago

  • Category set to Bugs in existing tests
  • Status changed from New to In Progress
  • Assignee set to okurz
Actions #2

Updated by okurz almost 6 years ago

version check should have been adapted with https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5400

but still comparing "good" (+) vs "bad" (-):

-   "ADDONURL" : null,
+   "ADDONURL" : "base,desktop,serverapp",
+   "ADDONURL_BASE" : "ftp://openqa.suse.de/SLE-15-Staging:G-Module-Basesystem-POOL-x86_64-Build489.1-Media1",
+   "ADDONURL_DESKTOP" : "ftp://openqa.suse.de/SLE-15-Staging:G-Module-Desktop-Applications-POOL-x86_64-Build489.1-Media1",
+   "ADDONURL_SERVERAPP" : "ftp://openqa.suse.de/SLE-15-Staging:G-Module-Server-Applications-POOL-x86_64-Build489.1-Media1",

see failure in https://openqa.suse.de/tests/1836081#

These addon urls are apparently added by a code section in products/sle/main.pm which generates the parts based on the WORKAROUND_MODULES. It seems that no code changes between good and bad have introduced any change there but that the service pack suffix is not handled correctly.

And nobody seems to have realized the perl warning "Use of uninitialized value $addonurl in substitution (s///) at /var/lib/openqa/cache/tests/sle/products/sle/main.pm line 299." :( I hate that. Why is it so hard to convince people that warnings should not be acceptable?

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5407 generated to show an explicit error message when the repos can not be accessed. What I see there is that the repo mentions a build id "F.6.5" which is also what the test has as build variable, this is also what the iso on osd has in the filename but the repo on osd is called "SLE-15-SP1-Staging:F-Module-Basesystem-POOL-x86_64-Build6.5-Media1" so "6.5" instead of "F.6.5". How did we mess this up?

Actions #3

Updated by okurz almost 6 years ago

  • Assignee changed from okurz to coolo

It seems rsync.pl is doing everything correct as it reads out the "build" from the media file which does not match with the "build" which is set on the installer ISO medium.

geekotest@openqa:~/share/factory/repo> cat SLE-15-SP1-Staging:F-Module-Basesystem-POOL-x86_64-Build6.5-Media1/media.1/media
SUSE - SLE-15-SP1-Module-Basesystem-POOL-x86_64-Build6.5-Media
SLE-15-SP1-Module-Basesystem-POOL-x86_64-Build6.5

so IMHO something is wrong on the side of how the project is built and this can have further consequences down the road. I do not want to patch neither rsync_sle.pm nor products/sle/main.pm to handle 15 different than 15-SP1.

@coolo please coordinate with RM+autobuild or advise.

Actions #4

Updated by coolo almost 6 years ago

  • Assignee changed from coolo to okurz

I'm not following

https://openqa.suse.de/tests/1836111#settings has

ISO SLE-15-SP1-Staging:F-Installer-DVD-x86_64-BuildF.6.6-Media1.iso
REPO_0 SLE-15-SP1-Staging:F-Installer-DVD-x86_64-BuildF.6.6-Media1
REPO_10 SLE-15-SP1-Staging:F-Module-Desktop-Applications-POOL-x86_64-Build6.6-Media1
REPO_11 SLE-15-SP1-Staging:F-Module-SAP-Applications-POOL-x86_64-Build6.6-Media1
REPO_12 SLE-15-SP1-Staging:F-Module-Server-Applications-POOL-x86_64-Build6.6-Media1
REPO_13 SLE-15-SP1-Staging:F-Module-Containers-POOL-x86_64-Build6.6-Media1
REPO_14 SLE-15-SP1-Staging:F-Module-Live-Patching-POOL-x86_64-Build6.6-Media1
REPO_15 SLE-15-SP1-Staging:F-Product-SLES-POOL-x86_64-Build6.6-Media1
REPO_16 SLE-15-SP1-Staging:F-Product-SLED-POOL-x86_64-Build6.6-Media1
REPO_17 SLE-15-SP1-Staging:F-Product-SLES_SAP-POOL-x86_64-Build6.6-Media1
REPO_18 SLE-15-SP1-Staging:F-Product-HPC-POOL-x86_64-Build6.6-Media1
REPO_19 SLE-15-SP1-Staging:F-Product-HA-POOL-x86_64-Build6.6-Media1
REPO_9 SLE-15-SP1-Staging:F-Module-Basesystem-POOL-x86_64-Build6.6-Media1

-> all build 6.6 and synced.

Still "ADDONURL": null

Actions #5

Updated by coolo almost 6 years ago

  • Assignee deleted (okurz)

ah, now I reread and you expect a F6.6

Actions #6

Updated by coolo almost 6 years ago

  • Assignee set to riafarov

That additional F is injected by rsync.pl - it's published as 6.6: http://download.suse.de/ibs/SUSE:/SLE-15-SP1:/GA:/Staging:/F/images/iso/

Looks like we need Rodion here :)

Actions #7

Updated by riafarov almost 6 years ago

Will get it fixed by the end of the day (I hope) ;)

Actions #8

Updated by okurz almost 6 years ago

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5415

Triggered a new set tests as geekotest on osd:

cd /opt/openqa-scripts
./rsync.pl --verbose --add-existing sle15_sp1_staging_f |& tee /tmp/rsync_sle15_sp1_staging_f_$(date +%F).log

output

{
   "ARCH" : "x86_64",
   "BUILD" : "F.6.6",
   "BUILD_SLE" : "F.6.6",
   "DISTRI" : "SLE",
   "FLAVOR" : "Installer-DVD-Staging:F",
   "ISO" : "SLE-15-SP1-Staging:F-Installer-DVD-x86_64-BuildF.6.6-Media1.iso",
   "REPO_0" : "SLE-15-SP1-Staging:F-Installer-DVD-x86_64-BuildF.6.6-Media1",
   "REPO_10" : "SLE-15-SP1-Staging:F-Module-Desktop-Applications-POOL-x86_64-Build6.6-Media1",
   "REPO_11" : "SLE-15-SP1-Staging:F-Module-SAP-Applications-POOL-x86_64-Build6.6-Media1",
   "REPO_12" : "SLE-15-SP1-Staging:F-Module-Server-Applications-POOL-x86_64-Build6.6-Media1",
   "REPO_13" : "SLE-15-SP1-Staging:F-Module-Containers-POOL-x86_64-Build6.6-Media1",
   "REPO_14" : "SLE-15-SP1-Staging:F-Module-Live-Patching-POOL-x86_64-Build6.6-Media1",
   "REPO_15" : "SLE-15-SP1-Staging:F-Product-SLES-POOL-x86_64-Build6.6-Media1",
   "REPO_16" : "SLE-15-SP1-Staging:F-Product-SLED-POOL-x86_64-Build6.6-Media1",
   "REPO_17" : "SLE-15-SP1-Staging:F-Product-SLES_SAP-POOL-x86_64-Build6.6-Media1",
   "REPO_18" : "SLE-15-SP1-Staging:F-Product-HPC-POOL-x86_64-Build6.6-Media1",
   "REPO_19" : "SLE-15-SP1-Staging:F-Product-HA-POOL-x86_64-Build6.6-Media1",
   "REPO_9" : "SLE-15-SP1-Staging:F-Module-Basesystem-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_MODULE_BASESYSTEM" : "SLE-15-SP1-Staging:F-Module-Basesystem-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_MODULE_CONTAINERS" : "SLE-15-SP1-Staging:F-Module-Containers-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_MODULE_DESKTOP_APPLICATIONS" : "SLE-15-SP1-Staging:F-Module-Desktop-Applications-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_MODULE_LIVE_PATCHING" : "SLE-15-SP1-Staging:F-Module-Live-Patching-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_MODULE_SAP_APPLICATIONS" : "SLE-15-SP1-Staging:F-Module-SAP-Applications-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_MODULE_SERVER_APPLICATIONS" : "SLE-15-SP1-Staging:F-Module-Server-Applications-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_PRODUCT_HA" : "SLE-15-SP1-Staging:F-Product-HA-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_PRODUCT_HPC" : "SLE-15-SP1-Staging:F-Product-HPC-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_PRODUCT_SLED" : "SLE-15-SP1-Staging:F-Product-SLED-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_PRODUCT_SLES" : "SLE-15-SP1-Staging:F-Product-SLES-POOL-x86_64-Build6.6-Media1",
   "REPO_SLE15_SP1_PRODUCT_SLES_SAP" : "SLE-15-SP1-Staging:F-Product-SLES_SAP-POOL-x86_64-Build6.6-Media1",
   "STAGING" : "F",
   "VERSION" : "15-SP1"
}

and then

openqa-client --params /var/lib/openqa/share/factory/iso/SLE-15-SP1-Staging\:F-Installer-DVD-x86_64-BuildF.6.6-Media1.iso.0.json isos post

-> https://openqa.suse.de/tests/overview?distri=sle&version=15-SP1&build=F.6.6&groupid=125

Actions #9

Updated by riafarov almost 6 years ago

I've retriggered all failed jobs, look fine. Problem was that version is 15-SP1 and we didn't expect dash to be there, so tried to read wrong variable and then there was a fallback to guess url, but build includes letter, which was always there in rsync.pl for staging.

Actions #10

Updated by riafarov almost 6 years ago

  • Status changed from In Progress to Feedback
Actions #11

Updated by riafarov almost 6 years ago

  • Status changed from Feedback to Resolved
Actions #12

Updated by okurz almost 6 years ago

  • Related to action #38732: [sle][functional][y] test fails in addon_products_sle - Add hint to test if ADDONURL isn't set added
Actions

Also available in: Atom PDF