Project

General

Profile

action #25370

[opensuse]Do not launch firefox from xterm in firefox_audio

Added by mlin7442 about 5 years ago. Updated almost 5 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Enhancement to existing tests
Target version:
-
Start date:
2017-09-18
Due date:
% Done:

90%

Estimated time:
Difficulty:

Description

Description

Observation
With https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/3327 firefox_audio now launch firefox from xterm, it is not normal behavior from customer,
it should launch firefox from desktop launcher like what firefox_audio test did in the past.

History

#1 Updated by okurz about 5 years ago

  • Subject changed from Do not launch firefox from xterm in firefox_audio to [opensuse]Do not launch firefox from xterm in firefox_audio
  • Assignee set to vsvecova

#2 Updated by okurz about 5 years ago

I agree that firefox should not be started from xterm, that's too far away from good customer experience. IMHO the usual way of debugging using any log output in e.g. ~/.xsession-errors* should be used.

#3 Updated by vsvecova almost 5 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

I have opened a pull request that changes the firefox_audio behavior back to launching firefox directly from launcher.

PR: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/3675

Verification run:
SLE12 SP2: http://dreamyhamster.suse.cz/tests/800#step/firefox_audio/9
SLE12 SP3: http://dreamyhamster.suse.cz/tests/799#step/firefox_audio/9

Needles: N/A

#4 Updated by coolo almost 5 years ago

I would close this and the PR with Rejected - the generic function is very handy to verify firefox is really stopped before we start the next firefox test. This might be a bit unlike what users do - but then again, users don't start firefoxes with fresh configs 10 times in a row either.

#5 Updated by vsvecova almost 5 years ago

So if I understand this correctly, this is mostly a conflict between the authenticity of the test behavior on one side, and ease of test debugging and maintenance on the other side.

Personally, I can understand the reasoning behind both arguments, although I would tend to stand by coolo's suggestion.
Do we have any generic guidelines as to which approach should take the preference?

#6 Updated by coolo almost 5 years ago

In doubt do as a manual test would be outlined. If the test case is 'start firefox on clean config', then I find it natural to start it from a terminal.

#7 Updated by vsvecova almost 5 years ago

  • Status changed from In Progress to Rejected

I see.

Ok then, given that the PR is already closed, I will close this issue likewise.

Whoever wishes to voice a different opinion and continue this discussion, can of course reopen.

Also available in: Atom PDF