Project

General

Profile

action #19226

[regression] script run dies

Added by dimstar over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Concrete Bugs
Target version:
-
Start date:
2017-05-18
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Test run used for analysis: https://openqa.opensuse.org/tests/405291#step/network_configuration/7

the script run correctly output "1Q7_W-0-" in serial0.txt, indicating that the command was successful.

From autoinst.txt though:

Argument "1Q7_W-0-\r\n" isn't numeric in numeric eq (==) at /usr/lib/os-autoinst/testapi.pm line 734.

This issue was introduced with https://github.com/os-autoinst/os-autoinst/commit/3bba01e77adf5dea58c1cbd538e74f8990c25742, where we now have:

     my $ret = wait_serial("$str-\\d+-", $wait);
     _handle_script_run_ret($ret, $cmd);

$ret will contain the entire string as returned on the serial console (e.g. 1Q7_W-0), which is then compared in _handle_script_run_ret at:

    croak $die_msg unless ($ret == 0);

$ret being the entire string from the serial, not stripped to the actual return code, causes this error


Related issues

Related to openQA Project - action #19224: Argument isn't numeric in numeric eq (==) at /usr/lib/os-autoinst/testapi.pm line 734.Resolved2017-05-18

History

#1 Updated by okurz over 5 years ago

  • Related to action #19224: Argument isn't numeric in numeric eq (==) at /usr/lib/os-autoinst/testapi.pm line 734. added

#2 Updated by okurz over 5 years ago

  • Status changed from New to In Progress
  • Assignee set to okurz

#3 Updated by okurz over 5 years ago

  • Project changed from openQA Tests to openQA Project
  • Category changed from Bugs in existing tests to Concrete Bugs
  • Status changed from In Progress to Feedback

https://github.com/os-autoinst/os-autoinst/pull/779 from mnowak should fix it. Waiting for deployment.

#4 Updated by okurz over 5 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF