action #17172
closed[tools][dashboard]"todo=1" does not show softfailed job with failed modules and no bugref
0%
Description
observation¶
https://openqa.suse.de/tests/overview?arch=&distri=sle&version=12-SP3&build=0078%400247&groupid=64# currently shows two failed jobs with a poo# reference and one softfailed job with two failed modules. Activating "todo=1" does not show any jobs anymore whereas the softfailed job with failed modules but no bugref should show up, shouldn't it?
steps to reproduce¶
- go to https://openqa.suse.de/tests/overview?arch=&distri=sle&version=12-SP3&build=0078%400247&groupid=64#
- observe that one softfailed job with no bugref shows up
- activate "todo=1"
- observe no job left
problem¶
Is this correct?
workaround¶
look for the job manually with "todo" not enabled.
Updated by okurz about 7 years ago
Very likely a regression introduced by
commit fe2fa2b
Author: Marius Kittler mkittler@suse.de
Date: Tue Jan 24 14:35:21 2017 +0100
Synchronize 'TODO' filter with review badges
so only jobs that need to be labeled for the black certificate
icon are shown when 'TODO' filter enabled
See https://progress.opensuse.org/issues/16124
which says it should show "jobs that need to be labeled for the black certificate", not the "grey certificate" so it should softfailed job with failed modules.
Updated by okurz about 7 years ago
maybe a problem with counting bugrefs and just comparing to the number of "to be reviewed" jobs as the one failed job has two bugrefs.
Updated by mkittler about 7 years ago
- Status changed from New to In Progress
Actually the 'Synchronize' commit just hides all soft failures which have at least one failed module - no matter whether there are bugrefs or not. I think I'll have to change it so it will hide only those where all failed modules are reviewed.
Updated by mkittler about 7 years ago
Updated by okurz about 7 years ago
- Status changed from In Progress to Feedback
merged, needs verification after deployment
Updated by RBrownSUSE about 7 years ago
- Subject changed from "todo=1" does not show softfailed job with failed modules and no bugref to [tools]"todo=1" does not show softfailed job with failed modules and no bugref
Updated by RBrownSUSE about 7 years ago
- Subject changed from [tools]"todo=1" does not show softfailed job with failed modules and no bugref to [tools][dashboard]"todo=1" does not show softfailed job with failed modules and no bugref
Updated by okurz almost 7 years ago
- Status changed from Feedback to Resolved
Implicitly done by https://github.com/os-autoinst/openQA/pull/1266