action #13574: MinimalX staging takes 20 minutes longer than it should - openQA Tests - openSUSE Project Management Tool

Actions

Copy link

action #13574

closed

MinimalX staging takes 20 minutes longer than it should

Added by RBrownSUSE over 7 years ago. Updated over 7 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

okurz

Category:

Bugs in existing tests

Target version:

Start date:

2016-09-02

Due date:

% Done:

Estimated time:

Difficulty:

Description

eg. https://openqa.suse.de/tests/538641

first_boot wastes 20 seconds because of

my $retry = 2;
# Check for errors during first boot
while ($retry) {
    # GNOME and KDE get into screenlock after 5 minutes without activities.
    # using 300 seconds here then we can get the wrong desktop screenshot at least
    # in case desktop screenshot changed, otherwise we get the screenlock screenshot.
    my $ret = check_screen "generic-desktop", 300;
    if ($ret) {
        mouse_hide();
        last;
    }
    else {
.... etc

We should not waste that time when GNOME or KDE is not DESKTOP

Actions

Copy link

Updated by okurz over 7 years ago

Status changed from New to In Progress
Assignee set to okurz

RBrownSUSE's own change: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/1793
merged.

Additional improvements:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/1794

For the record: The staging test would only take so much longer when there was no match on the display manager, mainly because of #12852. This is also because of the currently running test module not updating screenshots until the test module is done so it's misleading from the "live" view when it just waits for many minutes on the display manager.

Actions

Copy link

Updated by okurz over 7 years ago

PR merged, validation in production: https://openqa.opensuse.org/tests/255837

Code is cleaner now and should be more robust. As we want to preserve the behavior to check in cycles we can't simply change the check_screen to an assert_screen. But don't get confused by the comment in https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/1794/files#diff-58cde5170bbf5502424b304d908e7c7eR72 even though it refers to gnome and KDE only as the bootup process could take some time in all occassions. Now, one more possible improvement could be to reduce the timeout if a login was actually necessary just in before as the time from display manager to logged in session should be much smaller than complete boot time.

Actions

Copy link