https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842022-06-23T09:46:16ZopenSUSE Project Management ToolopenQA Infrastructure - action #112916: postgresql.conf is invalid after recent salt changes size:Mhttps://progress.opensuse.org/issues/112916?journal_id=5319532022-06-23T09:46:16Zlivdywanliv.dywan@suse.com
<ul><li><strong>Copied from</strong> <i><a class="issue tracker-6 status-3 priority-4 priority-default closed child parent" href="/issues/112718">coordination #112718</a>: [alert][osd] openqa.suse.de is not reachable anymore, response times > 30s, multiple alerts over the weekend</i> added</li></ul> openQA Infrastructure - action #112916: postgresql.conf is invalid after recent salt changes size:Mhttps://progress.opensuse.org/issues/112916?journal_id=5319682022-06-23T09:47:22Ztinitatina.mueller+trick-redmine@suse.com
<ul><li><strong>Subject</strong> changed from <i>posttgresql.conf is invalid after recent salt changes size:M</i> to <i>postgresql.conf is invalid after recent salt changes size:M</i></li></ul> openQA Infrastructure - action #112916: postgresql.conf is invalid after recent salt changes size:Mhttps://progress.opensuse.org/issues/112916?journal_id=5319982022-06-23T10:10:33Zokurzokurz@suse.com
<ul><li><strong>Tracker</strong> changed from <i>coordination</i> to <i>action</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p>manually reverting the config file from <a href="https://gitlab.suse.de/openqa/salt-states-openqa/-/jobs/1026706#L1434" class="external">https://gitlab.suse.de/openqa/salt-states-openqa/-/jobs/1026706#L1434</a> and restarted the postgresql service. The file was shortly overwritten again, likely by salt, but nevermind because I will fix that soon in the salt repo. But in the broken state I called in psql <code>select pg_reload_conf();</code> which still shows "t" despite the config being invalid. This is in line with <a href="https://stackoverflow.com/questions/16333319/how-to-syntax-check-postgresql-config-files#comment101836284_55758799" class="external">https://stackoverflow.com/questions/16333319/how-to-syntax-check-postgresql-config-files#comment101836284_55758799</a> which also states that this does not work. Also <a href="https://stackoverflow.com/a/16340569" class="external">https://stackoverflow.com/a/16340569</a> states that there is no separate check config command. One needs to try to restart the server which refuses to load an invalid config.</p>
<p><a href="https://github.com/os-autoinst/salt-states-openqa/blob/master/openqa/server.sls#L330" class="external">https://github.com/os-autoinst/salt-states-openqa/blob/master/openqa/server.sls#L330</a> is within a block <code>{%- if not grains.get('noservices', False) %}</code> so we won't see those rules effective in CI jobs.</p>
openQA Infrastructure - action #112916: postgresql.conf is invalid after recent salt changes size:Mhttps://progress.opensuse.org/issues/112916?journal_id=5320222022-06-23T10:38:53Zokurzokurz@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul><p>Manually testing the changes on OSD in a separate file with<br>
<code>salt-call --local -l error --state-output=changes state.sls_id postgresql-work_mem2 openqa.postgresql test=True</code><br>
which takes about 10s each run – why is salt so slow – but ok.</p>
<p>Trying out the pattern manually with grep or sed is fine but with salt the replacement ends up as <code>tMB</code></p>
<p><a href="https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/705" class="external">https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/705</a></p>
openQA Infrastructure - action #112916: postgresql.conf is invalid after recent salt changes size:Mhttps://progress.opensuse.org/issues/112916?journal_id=5320252022-06-23T10:39:42Zokurzokurz@suse.com
<ul><li><strong>Due date</strong> set to <i>2022-07-07</i></li></ul> openQA Infrastructure - action #112916: postgresql.conf is invalid after recent salt changes size:Mhttps://progress.opensuse.org/issues/112916?journal_id=5342482022-07-06T11:59:02Zokurzokurz@suse.com
<ul><li><strong>Due date</strong> deleted (<del><i>2022-07-07</i></del>)</li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>We crosschecked and it's all good</p>