Project

General

Profile

Actions

action #10552

closed

parse_junit_log function doesn't add prefix to file name as upload_logs does

Added by jtzhao about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
-
Start date:
2016-02-03
Due date:
% Done:

100%

Estimated time:

Description

In commit 94c1bda656b23c40ae08be1885022440bd20dbeb, test api upload_logs adds current test name as a prefix to the uploaded log files' names. But parse_junit_log doesn't do the same. As a result, it won't be able to find the uploaded junit file.

Actions #1

Updated by oholecek about 8 years ago

I'm sorry, but is this really happening somewhere? Btw. the commit you mentioned deals only with documentation, commit c490d2c721f0e21a101f27ed7a671b0b0cc33961 does change upload_logs behaviour but that should be transparent to other functions. It does not alter filename. Or am I missing something?

Actions #2

Updated by jtzhao about 8 years ago

oholecek wrote:

I'm sorry, but is this really happening somewhere? Btw. the commit you mentioned deals only with documentation, commit c490d2c721f0e21a101f27ed7a671b0b0cc33961 does change upload_logs behaviour but that should be transparent to other functions. It does not alter filename. Or am I missing something?

Test api parse_junit_log invokes upload_logs to upload the junit xml file, and parses it. The problem is, upload_logs changes the file name but parse_junit_log tries to open the file with the original name.

I've created a pull request: https://github.com/os-autoinst/os-autoinst/pull/413

Actions #3

Updated by oholecek about 8 years ago

Yeah, I missed the line it reads it from uploads directory.

Actions #4

Updated by jtzhao about 8 years ago

  • Status changed from New to Resolved
Actions #5

Updated by jtzhao about 8 years ago

  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF