Actions
action #61164
closedUse of uninitialized value / unhandled debug output in os-autoinst t/17-basetest.t
Description
Observation¶
From https://build.opensuse.org/package/live_build_log/devel:openQA/os-autoinst/SLE_12_SP5/x86_64 :
[ 184s] Use of uninitialized value in multiplication (*) at /home/abuild/rpmbuild/BUILD/os-autoinst-4.6.1576562911.842eb808/basetest.pm line 219.
[ 184s] [2019-12-18T21:18:00.715 UTC] [debug] needle 'check-workaround-hash-20190522' is a workaround. The reason is bsc#7654321: this is a test about workaround.
[ 184s] 17-basetest.t .......................... ok
Acceptance criteria¶
- DONE:
AC1: No perl warning about uninitialized value in os-autoinst t/17-basetest.t -> https://github.com/os-autoinst/os-autoinst/pull/1331 - AC2: No unhandled debug output in os-autoinst t/17-basetest.t
Suggestions¶
- Execute t/17-basetest.t locally, e.g.
prove -I. t/17-basetest.t
- Ensure all output is caught with
Test::Output
so that there is only the prove summary output
Updated by okurz almost 5 years ago
- Copied to action #61167: "Possible attempt to separate words with commas" in os-autoinst t/18-qemu.t added
Updated by Xiaojing_liu almost 5 years ago
- Assignee set to Xiaojing_liu
- Target version set to Current Sprint
Updated by Xiaojing_liu almost 5 years ago
- Status changed from New to In Progress
Updated by okurz almost 5 years ago
merged, great! If you like to give a go at the "unhandled debug output" you can stay on the ticket otherwise I suggest to unassign.
Updated by Xiaojing_liu almost 5 years ago
okurz wrote:
merged, great! If you like to give a go at the "unhandled debug output" you can stay on the ticket otherwise I suggest to unassign.
I am not sure how to give a go so I set it to unassign.
Updated by livdywan almost 5 years ago
- Status changed from In Progress to Feedback
Seems like this needs to be discussed a bit more
Updated by okurz almost 5 years ago
- Status changed from Feedback to Workable
- Target version deleted (
Current Sprint)
What needs to be done is to cover the calls in the unit test with Test::Output
Updated by okurz almost 4 years ago
- Status changed from Workable to Feedback
- Assignee set to okurz
Actions